Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates
 209.85.220.41 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <cffff7e0f25e425fba8ab5aafea85968@BN1PR07MB135.namprd07.prod.outlook.com>
References: 
 <10d6b39f18a4425fbaa5355a5d4aa240@BN1PR07MB135.namprd07.prod.outlook.com>
 <CAMk5LL=F+a0L-ZnmCbX5nqW4jPTFuVq-aiV0aLduF4bvDWCqwg@mail.gmail.com>
 <1d7adcd3150e42d3a7a4f7b6159095b9@BN1PR07MB135.namprd07.prod.outlook.com>
 <CAMk5LLmeCBhb5Ad4c8BG_09U-ieqs1xtf5=dPwK7-0z3D9CJUA@mail.gmail.com>
 <cffff7e0f25e425fba8ab5aafea85968@BN1PR07MB135.namprd07.prod.outlook.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Wed, 12 Feb 2014 22:22:49 -0500
Message-ID: 
 <CABiQX1XgFuG8R2cj9RJZcb9-ngXtFcgWxBvPmCFJq+0QETFpcw@mail.gmail.com>
Subject: Re: Engine confusion
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a1134b978675df504f2413538

--001a1134b978675df504f2413538
Content-Type: text/plain; charset=UTF-8

On Wed, Feb 12, 2014 at 5:19 PM, Jonathan Bond-Caron <
jbondc@gdesolutions.com> wrote:

> On Wed Feb 12 03:56 PM, Braden Shepherdson wrote:
> > Do the check the same file? I thought they were different. They might
> > check the
> > same path in different platforms, but that script can
> > return different things. I
> > would consider that a bug as well.
> >
> > I don't see anything to be gained from changing the syntax.
> >
>
> They check the same *relative file* to the platform/project directory (so
> ya can have different version script per platform).
> Makes sense it was done that way in the beginning but could be improved
> now.
>
> a) Issue is other/newer platforms don't have the 'check for version x'.
>
> b) More a personal preference for:
> <engine name="cordova" version=">=3.0.0"/>
> <engine name="cordova" version=">=3.3.0" platform="android"/>
>
> I can patch the code so that:
> <engine name="cordova-android" version=">=3.3.0" />
> <engine name="cordova-{$supported_platform} " version=">=3.3.0" />
>
>
- Agree that the first example is more intuitive.
- Based on our 3.0+ version scheme, it's possible for cordova-ios= 4.0
while cordova-cli = 3.5. So, another option here is to make cordova-ios
check  platforms/ios/cordova/version and "cordova" use CLI's version


> Still works but is deprecated for 4.0
>
> If "cordova" is meant to check the cli version, from what I can tell
> hasn't been that way since Aug 2013
>
> J
>
>

--001a1134b978675df504f2413538--