cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Framework support via plugman + plugin spec
Date Tue, 25 Feb 2014 22:35:41 GMT
Plugman's install.js has this nice little gem in the source [0]:

frameworkFiles = platformTag.findall('./framework[@custom="true"]'), //
CB-5238 adding only custom frameworks

Looking through CB-5238[1], and the related issues [2][3] I have some
questions.

1. How do we add a non-custom framework?
2. What is the point of having an attribute that we only accept one value
for?
3. The docs [4] state that the default is false, but the code does not do
anything unless @custom is 'true', where is the disconnect?

[0]
https://github.com/apache/cordova-plugman/blob/master/src/install.js#L362
[1] https://issues.apache.org/jira/browse/CB-5238
[2] https://issues.apache.org/jira/browse/CB-5682
[3] https://issues.apache.org/jira/browse/CB-5949
[4] http://cordova.apache.org/docs/en/edge/plugin_ref_spec.md



@purplecabbage
risingj.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message