cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject cordova launcher icon support https://github.com/apache/cordova-cli/pull/126
Date Mon, 10 Feb 2014 14:07:19 GMT
Andrew,

any comments to the current implementation?
https://github.com/apache/cordova-cli/pull/126

Joe commented that the new class in config_parser.js named "icon" should be
named "Icon" but I left it as is because the other classes are lowercase
too.
There was another comment that namespaces in config.xml attributes are
SchnickSchnack/chatter.
I think that we should use the cordava namespace if config.xml deviates
from the W3C widget definition.
These two are the only comments I got.

I tested this on Android and FirefoxOS.

Any chance to accept the request (at least the Android part)?

-Axel

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message