cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject Re: Started Implementing CB-2606 Add support for <icon in config.xml
Date Sat, 08 Feb 2014 10:51:49 GMT
I removed the restriction that icons live in specific directories.
https://github.com/apache/cordova-cli/pull/126

The src in the icon element in config.xml is taken as is.

-Axel


    <icon src="/res/android/icons/icon.png" cdv:platform="android" />
    <icon src="/res/android/icons/icon-ldpi.png" cdv:platform="android"
cdv:density="ldpi" />
    <icon src="/res/android/icons/icon-mdpi.png" cdv:platform="android"
cdv:density="mdpi" />
    <icon src="/res/android/icons/icon-hdpi.png" cdv:platform="android"
cdv:density="hdpi" />
    <icon src="/res/android/icons/icon-xhdpi.png" cdv:platform="android"
cdv:density="xhdpi" />



2014-01-08 20:48 GMT+01:00 Axel Nennker <ignisvulpis@gmail.com>:

> True, will make it so.
>
>
> 2014/1/8 Andrew Grieve <agrieve@chromium.org>
>
>> The change has landed (minus docs on cordova-docs), but we'll have to
>> support config.xml being in the root or in www/. What that means for file
>> paths I'm not sure. Maybe just say regardless of where the .xml file is
>> make paths relative to the project root?
>>
>>
>> No idea about namespaces.
>>
>>
>> On Wed, Jan 8, 2014 at 10:31 AM, Axel Nennker <ignisvulpis@gmail.com>
>> wrote:
>>
>> > I think I'll wait for when "www/config.xml -> config.xml" has landed
>> before
>> > continuing with this, right?!
>> > Axel
>> >
>> > ps:
>> > Does the xml parser handle name spaces correctly?
>> > That is: How do I find an element in a certain namespace regardless of
>> > prefix?
>> >
>> >
>> https://github.com/AxelNennker/cordova-cli/blob/master/src/config_parser.js#L249
>> > Can I write something like
>> >
>> > els = this.config.doc.findall('icon', '
>> http://cordova.apache.org/ns/1.0');
>> >
>> > in elementree?
>> >
>> >
>> >
>> >
>> >
>> > 2013/12/22 Axel Nennker <ignisvulpis@gmail.com>
>> >
>> > > Now with firefoxos support which lacked support for the mandatory
>> icons
>> > > field in the manifest before this patch.
>> > >
>> > >
>> >
>> https://github.com/AxelNennker/cordova-cli/blob/master/src/metadata/firefoxos_parser.js#L63
>> > >
>> > > -Axel
>> > >
>> > >
>> > > 2013/12/20 Axel Nennker <ignisvulpis@gmail.com>
>> > >
>> > >> The xmlns is in the config.xml of the 3.3 HelloWorld app.
>> > >>
>> > >> <widget id="com.example.hello" version="0.0.1" xmlns="
>> > >> http://www.w3.org/ns/widgets" xmlns:cdv="
>> > http://cordova.apache.org/ns/1.0
>> > >> ">
>> > >>
>> > >> -Axel
>> > >>
>> > >>
>> > >> Am 20.12.2013 18:08 schrieb "Josh Soref" <jsoref@blackberry.com>:
>> > >>
>> > >>  Andrew wrote:
>> > >>> > Should CLI be in the business of resizing icons or converting
>> image
>> > >>> formats?
>> > >>>
>> > >>> Probably not
>> > >>>
>> > >>> > Should you have to supply an icon for each platform separately,
or
>> > >>> should
>> > >>> > we support one <icon> tag that will be used as the default
for
>> > >>> all platforms?
>> > >>>
>> > >>> Different platforms may have different icon styles.
>> > >>>
>> > >>> > Specifying the platform should not be the norm. It should
be
>> enough
>> > >>> > to have a bunch if <icon src=foo density=bar>, and platforms
will
>> > pick
>> > >>> up
>> > >>> > the sizes of icons that they require.
>> > >>>
>> > >>> > I realize this is "proper" XML, since they aren't a part of
the
>> > widget
>> > >>>
>> > >>> Proper involves an xmlns which I didn't see.
>> > >>>
>> ---------------------------------------------------------------------
>> > >>> This transmission (including any attachments) may contain
>> confidential
>> > >>> information, privileged material (including material protected
by
>> the
>> > >>> solicitor-client or other applicable privileges), or constitute
>> > non-public
>> > >>> information. Any use of this information by anyone other than the
>> > intended
>> > >>> recipient is prohibited. If you have received this transmission
in
>> > error,
>> > >>> please immediately reply to the sender and delete this information
>> from
>> > >>> your system. Use, dissemination, distribution, or reproduction
of
>> this
>> > >>> transmission by unintended recipients is not authorized and may
be
>> > unlawful.
>> > >>>
>> > >>
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message