cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: cordova launcher icon support https://github.com/apache/cordova-cli/pull/126
Date Mon, 10 Feb 2014 15:55:42 GMT
He Axel, thanks for spearheading this. Will have a look shortly.


On Mon, Feb 10, 2014 at 9:07 AM, Axel Nennker <ignisvulpis@gmail.com> wrote:

> Andrew,
>
> any comments to the current implementation?
> https://github.com/apache/cordova-cli/pull/126
>
> Joe commented that the new class in config_parser.js named "icon" should
> be named "Icon" but I left it as is because the other classes are lowercase
> too.
> There was another comment that namespaces in config.xml attributes are
> SchnickSchnack/chatter.
> I think that we should use the cordava namespace if config.xml deviates
> from the W3C widget definition.
> These two are the only comments I got.
>
> I tested this on Android and FirefoxOS.
>
> Any chance to accept the request (at least the Android part)?
>
> -Axel
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message