cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Engine confusion
Date Thu, 13 Feb 2014 03:26:14 GMT
On Wed, Feb 12, 2014 at 10:22 PM, Andrew Grieve <agrieve@chromium.org>wrote:

>
>
>
> On Wed, Feb 12, 2014 at 5:19 PM, Jonathan Bond-Caron <
> jbondc@gdesolutions.com> wrote:
>
>> On Wed Feb 12 03:56 PM, Braden Shepherdson wrote:
>> > Do the check the same file? I thought they were different. They might
>> > check the
>> > same path in different platforms, but that script can
>> > return different things. I
>> > would consider that a bug as well.
>> >
>> > I don't see anything to be gained from changing the syntax.
>> >
>>
>> They check the same *relative file* to the platform/project directory (so
>> ya can have different version script per platform).
>> Makes sense it was done that way in the beginning but could be improved
>> now.
>>
>> a) Issue is other/newer platforms don't have the 'check for version x'.
>>
>> b) More a personal preference for:
>> <engine name="cordova" version=">=3.0.0"/>
>> <engine name="cordova" version=">=3.3.0" platform="android"/>
>>
>> I can patch the code so that:
>> <engine name="cordova-android" version=">=3.3.0" />
>> <engine name="cordova-{$supported_platform} " version=">=3.3.0" />
>>
>>
> - Agree that the first example is more intuitive.
> - Based on our 3.0+ version scheme, it's possible for cordova-ios= 4.0
> while cordova-cli = 3.5. So, another option here is to make cordova-ios
> check  platforms/ios/cordova/version and "cordova" use CLI's version
>

Hmm, to get this right though, you'd want to do: <engine name="cordova-ios"
version=">3.5" platform="ios"/>.

Note that plugman is the one doing these checks, not CLI, so to fix this,
plugman will need to keep a map of platformVersion -> cadenceVersion.


>
>
>
>> Still works but is deprecated for 4.0
>>
>> If "cordova" is meant to check the cli version, from what I can tell
>> hasn't been that way since Aug 2013
>>
>> J
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message