cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Bond-Caron <jbo...@gdesolutions.com>
Subject RE: Engine confusion
Date Thu, 13 Feb 2014 13:56:11 GMT
On Wed Feb 12 10:22 PM, Andrew Grieve wrote:
> > b) More a personal preference for:
> > <engine name="cordova" version=">=3.0.0"/> <engine name="cordova"
> > version=">=3.3.0" platform="android"/>
> >
> > I can patch the code so that:
> > <engine name="cordova-android" version=">=3.3.0" /> <engine
> > name="cordova-{$supported_platform} " version=">=3.3.0" />
> >
> >
> - Agree that the first example is more intuitive.
> - Based on our 3.0+ version scheme, it's possible for cordova-ios= 4.0 while
> cordova-cli = 3.5. So, another option here is to make cordova-ios check
> platforms/ios/cordova/version and "cordova" use CLI's version
> 

I think I appropriately picked the e-mail topic :)

I prefer:
<engine name="cordova" version=">=3.0.0"/>
<engine name="cordova" version=">=3.3.0" platform="ios"/>

Before it implies cordova is the "engine"

<engine name="cordova-ios" version=">=3.0.0"/>
<engine name="cordova-android" version=">=3.0.0"/>

Implies there's 1+ cordova engines, which I'm not really sure what that means.

It's really "cordova" engine for platform "foo"
<engine name="cordova" version=">=3.3.0" platform="foo"/>

Odd part in the code is "cordova" check gets dropped *if* "cordova-platform" exists:
https://github.com/jbondc/cordova-plugman/blob/master/src/install.js#L212

I don't think that how people expect it to work, hence the confusion. "cordova" doesn't refer
to the cordova-cli version

J

Mime
View raw message