cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <purplecabb...@gmail.com>
Subject Re: [Vote] Cordova 3.4.0 release
Date Wed, 19 Feb 2014 05:59:52 GMT
IMO, If it was not in the release candidate, it should not be pushed into the release. 

If we need to turn around and do a 3.4.1 to address an issue, then we can do that. 



> On Feb 18, 2014, at 6:16 PM, Andrew Grieve <agrieve@chromium.org> wrote:
> 
> -1
> 
> There's one iOS fix that I think we should put it (as is just being
> discussed on private ML).
> 
> 
>> On Tue, Feb 18, 2014 at 8:57 PM, sebb <sebbaz@gmail.com> wrote:
>> 
>> -1
>> 
>> The NOTICE file is incorrect.
>> 
>> The date still says 2012; it should be updated
>> 
>> The line
>> 
>> This product includes software developed by
>> 
>> should be [2]
>> 
>> This product includes software developed at
>> 
>> The distinction is important.
>> 
>> The source archive NOTICE file contains the wording
>> 
>> "This product includes software developed by
>> Ant-Contrib project (http://sourceforge.net/projects/ant-contrib). "
>> 
>> It seems this relates to ant-contrib-1.0b3.jar which as far as I can
>> tell is not *included* in the source archive.
>> 
>> Entries in the NOTICE file must ONLY relate to software that is
>> actually included.
>> Nothing may be added to the NOTICE file that is not legally required [1]
>> 
>> I was unable to check if the contents of the source archive agrees
>> with the source code control system - please supply the tag(s) from
>> which the source archive was created.
>> 
>> [1] http://www.apache.org/dev/licensing-howto.html#mod-notice
>> [2] http://www.apache.org/legal/src-headers.html#notice-text
>> 
>> 
>> 
>>> On 18 February 2014 23:26, Steven Gill <stevengill97@gmail.com> wrote:
>>> Please review and vote on the Cordova 3.4.0 release.
>>> 
>>> You can find the sample release at http://people.apache.org/~steven/
>>> 
>>> Voting will go on for 24 hours.
>>> 
>>> Cheers,
>>> 
>>> -Steve
>> 

Mime
View raw message