cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve" <agri...@chromium.org>
Subject Re: Review Request 17553: Throw when trying to create project inside custom www dir
Date Tue, 04 Feb 2014 03:31:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17553/#review33562
-----------------------------------------------------------

Ship it!


Merged

- Andrew Grieve


On Jan. 30, 2014, 9:37 p.m., Mark Koudritsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17553/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 9:37 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5947
>     https://issues.apache.org/jira/browse/CB-5947
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> If a custom www dir is provided and is a parent or the same as the project dir, cordova
create fails while trying to create an infinite file hierarchy. Detect and stop in this case.
> 
> 
> Diffs
> -----
> 
>   src/create.js 75b2621 
> 
> Diff: https://reviews.apache.org/r/17553/diff/
> 
> 
> Testing
> -------
> 
> npm test
> cordova create --srouce ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message