Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 124B110E17 for ; Thu, 16 Jan 2014 19:38:58 +0000 (UTC) Received: (qmail 52162 invoked by uid 500); 16 Jan 2014 19:38:57 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 52099 invoked by uid 500); 16 Jan 2014 19:38:57 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 52091 invoked by uid 99); 16 Jan 2014 19:38:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2014 19:38:57 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FH_RANDOM_SURE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of bowserj@gmail.com designates 74.125.82.41 as permitted sender) Received: from [74.125.82.41] (HELO mail-wg0-f41.google.com) (74.125.82.41) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2014 19:38:52 +0000 Received: by mail-wg0-f41.google.com with SMTP id n12so994160wgh.0 for ; Thu, 16 Jan 2014 11:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=FKB2h0+W7m8Be8CJc6E4996wWfzTqxMWrYM7dSM9rOE=; b=VR/Ghi3HpN9LOitGcZO/8QBdpilvswCxXLmM+lMtsKE8zcyPhtOlIH9PVpgTgxqwPE QCNqkQWA8bqxZDgqeaQXBvLWdkbv7qONZJbbCxwk2E+Q9nsaM/2vrBNJRYpINsLdaqET uh1qGvhGyczi4ECD1elJg7O03d9LRFDRFI6nk/I5zK5lvgPLAtCgLfAMsFOVuhGYzBQO +IS+wO/oeu+g4Q+IBoHhtNzNvSxx+teB2nkO8nDRLvTFup+yAwtw6BbbXoQ5vgmYdDsz QOCUb8CfTMxwgzsAA/asOGLiZ2Exr8CuUUI+VBap11QlHaFtVGBeWhZ4MqqehnVBkxDw crhQ== MIME-Version: 1.0 X-Received: by 10.180.76.103 with SMTP id j7mr9582526wiw.58.1389901111717; Thu, 16 Jan 2014 11:38:31 -0800 (PST) Received: by 10.217.63.201 with HTTP; Thu, 16 Jan 2014 11:38:31 -0800 (PST) Reply-To: bowserj@apache.org In-Reply-To: References: Date: Thu, 16 Jan 2014 11:38:31 -0800 Message-ID: Subject: Re: [Android] LAST CHANCE: Adding Drawables from AOSP to InAppBrowser to conform to OS guidelines From: Joe Bowser To: dev Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org This is merged in! We now have language neutral hawtness. We'll have to revisit this for accessibility, but at least we no longer have "Done" hardcoded. On Wed, Jan 15, 2014 at 2:32 PM, Joe Bowser wrote: > Hey > > I'm putting the final touches on the drawables fork, which will add > normal icons to the InAppBrowser so that it looks more like Android > and less like we half-assed it. I'm sure we'll re-do the UI again in > another re-write, but this looks good. > > The source can be found here: > https://github.com/infil00p/cordova-plugin-inappbrowser/tree/drawables > > I'll be merging this into the InAppBrowser plugin TOMORROW, so this is > a heads up to actually check this out beforehand. > > BTW: This is directly addressing this bug: CB-2495. The drawables are > customizable.