Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.192.181 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAEeF2TcLF4Okaks1niw4B7sYhQKVoWaOi8zQKndOdtkaRi5NNA@mail.gmail.com>
References: <DUB403-EAS24634C9AC5A5D3CCACBC3E78DCE0@phx.gbl>
 <CAD66QQTmP6OQATc4+C0NuO4j7cZ+hN=KfX1KLj-ePezCJejy4A@mail.gmail.com>
 <CABiQX1U1ScTcWK-uvMj5DXV5yvMv45RiwUOKkA16yY+VFyEUPQ@mail.gmail.com>
 <CABiQX1WLntiNzHZNdfpY0tzfgDfCrwmii70p_CKY_MCycP22Ng@mail.gmail.com>
 <CAEeF2Td0yFhV2WdkNkg_kkhVfQJrkmG_RnqLH1X2mdg0HzwkxQ@mail.gmail.com>
 <CABiQX1XaKJXGaqzyJvToCCDu-CcJx75C89MFFgeULG_P+VeZiA@mail.gmail.com>
 <CAEeF2TcLF4Okaks1niw4B7sYhQKVoWaOi8zQKndOdtkaRi5NNA@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Wed, 8 Jan 2014 09:48:51 -0800
Message-ID: 
 <CABiQX1W0AqaU6NUkYrUi7H-Q6P0H_LTMTDvzt9S7N4xBdB7_hQ@mail.gmail.com>
Subject: Re: Moving www/config.xml -> config.xml (within CLI)
To: Michal Mocny <mmocny@chromium.org>
Cc: Andrew Grieve <agrieve@chromium.org>, dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a11344808b291a804ef791c11

--001a11344808b291a804ef791c11
Content-Type: text/plain; charset=UTF-8

I've now made this change (see JIRA issue). You can try it out via git's
CLI. old projects see no change, but new project template now puts
config.xml as a sibling to www.


On Mon, Jan 6, 2014 at 12:11 PM, Michal Mocny <mmocny@chromium.org> wrote:

> After discussing this and reading the other thread (on config.json
> movement), I agree this is not the time for the rename.
>
>
> On Mon, Jan 6, 2014 at 2:58 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>
>> 1) Good point. Makes sense to me.
>>
>> 2) I think this is a tougher call. In on context, it does make more sense
>> as "app.xml", since "config.xml" is the thing you're generating as an
>> output. OTOH, there are a lot of tutorials & blog posts that say "put FOO
>> in your config.xml", and so renaming it would be confusing in this context.
>>
>>
>> On Mon, Jan 6, 2014 at 11:30 AM, Michal Mocny <mmocny@chromium.org>wrote:
>>
>>> 1) Wouldn't it make more sense to default to the root config.xml if both
>>> are present?  If you create a new project and import an old www project
>>> using a new CLI (--source or --link), you would get both configuration
>>> files (one at the root created by the template, and one inside your
>>> imported www).  Wouldn't you expect to use the new config file in this
>>> case, perhaps with a warning to delete the old one?  Not a big deal I guess
>>> if you have a warning in either case.
>>> 2) Do we want to rename config.xml to app.xml (or something else) to
>>> finally kill the confusion between "platform config.xml" vs "project
>>> config.xml"?
>>>
>>>
>>> On Fri, Jan 3, 2014 at 1:52 PM, Andrew Grieve <agrieve@chromium.org>wrote:
>>>
>>>> Looks like there's already a JIRA for this:
>>>>
>>>> https://issues.apache.org/jira/browse/CB-4910
>>>>
>>>>
>>>>
>>>> On Thu, Jan 2, 2014 at 10:35 AM, Andrew Grieve <agrieve@chromium.org>
>>>> wrote:
>>>>
>>>> > I'll make a JIRA issue on Tuesday and paste the link to it here.
>>>> >
>>>> >
>>>> > On Thu, Jan 2, 2014 at 10:32 AM, Ross Gerbasi <rgerbasi@gmail.com>
>>>> wrote:
>>>> >
>>>> >> Did this make it to jira? I also think its a good idea to pull
>>>> config.xml
>>>> >> out of the www root. Anyway to track this one?
>>>> >>
>>>> >>
>>>> >> On Mon, Dec 30, 2013 at 1:51 PM, Dick Van den Brink <
>>>> >> d_vandenbrink@outlook.com> wrote:
>>>> >>
>>>> >> > I think it is a a good idea! So a +1
>>>> >> >
>>>> >> > Sent from my Windows Phone
>>>> >> > ________________________________
>>>> >> > From: Axel Nennker<mailto:ignisvulpis@gmail.com>
>>>> >> > Sent: 12/30/2013 20:47
>>>> >> > To: dev<mailto:dev@cordova.apache.org>
>>>> >> > Subject: Re: Moving www/config.xml -> config.xml (within CLI)
>>>> >> >
>>>> >> > I support this proposal.
>>>> >> >
>>>> >> > When I started work on CB-2606
>>>> >> > https://issues.apache.org/jira/browse/CB-2606I noticed that the
>>>> >> > element <icon src="icon.png"... />
>>>> >> > suggests that icons are put next to config.xml as well.
>>>> >> > When config.xml is in the project root it becomes more natural to
>>>> put
>>>> >> icons
>>>> >> > in <project root>/res/icons/<platform>/icon.png
>>>> >> >
>>>> >> > -Axel
>>>> >> >
>>>> >> > ps:
>>>> >> > I need opinions on my current implementation of CB-2606.
>>>> >> > https://github.com/AxelNennker/cordova-cli
>>>> >> > Please chime in to the email thread with the subject "Started
>>>> >> Implementing
>>>> >> > CB-2606 Add support for <icon in config.xml"
>>>> >> >
>>>> >> >
>>>> >> >
>>>> >> > 2013/12/30 Andrew Grieve <agrieve@chromium.org>
>>>> >> >
>>>> >> > > I thought this was previously discussed, but I can't find any
>>>> JIRA
>>>> >> issues
>>>> >> > > or old emails about it.
>>>> >> > >
>>>> >> > > Proposal:
>>>> >> > > For CLI projects:
>>>> >> > > - Use www/config.xml if it exists
>>>> >> > > - Otherwise use ./config.xml
>>>> >> > > - Change the project template to use ./config.xml by default
>>>> >> > >
>>>> >> > >
>>>> >> > > Reasons:
>>>> >> > > - Paths in config.xml are relative to project root
>>>> >> > > - Prevents a copy of config.xml ended up in platforms/*/www
>>>> >> > > - Manifests are generally found at the top-level of projects.
>>>> >> > >
>>>> >> > >
>>>> >> > > Sound good? If so I'll make an issue and work on this. Since it's
>>>> >> > holidays,
>>>> >> > > will wait until next week Tuesday (Jan 7) to proceed.
>>>> >> > >
>>>> >> > > Andrew
>>>> >> > >
>>>> >> >
>>>> >>
>>>> >
>>>> >
>>>>
>>>
>>>
>>
>

--001a11344808b291a804ef791c11--