Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of kamrik@google.com designates
 209.85.128.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAKP6k2uxPe2Ae+C-FE7bXUypv=eofV+Bsbk4_ExOpXWSS9sBSQ@mail.gmail.com>
References: <20140108191525.11587.31548@reviews.apache.org>
	<CAKP6k2uxPe2Ae+C-FE7bXUypv=eofV+Bsbk4_ExOpXWSS9sBSQ@mail.gmail.com>
Date: Wed, 8 Jan 2014 14:52:13 -0500
Message-ID: 
 <CA+GVa3bJJpD=zjY+26ApAK5qHZ0E=N--mdmYQtONeMuq6g1dpw@mail.gmail.com>
Subject: Re: Review Request 16739: Change --searchpath to use repeated flag
 instead of delimiter
From: Mark Koudritsky <kamrik@google.com>
To: dev@cordova.apache.org
Cc: Mark Koudritsky <kamrik@gmail.com>
Content-Type: multipart/alternative; boundary=047d7b6d87ce4facc304ef7ad48b

--047d7b6d87ce4facc304ef7ad48b
Content-Type: text/plain; charset=UTF-8

I think the use of searchpath as command line param will be rare, in most
cases it will be stored in some config file (e.g. cordova.json) and it
would be much better to keep it there in a platform independent format.


On Wed, Jan 8, 2014 at 2:28 PM, Jesse <purplecabbage@gmail.com> wrote:

> I think we should be using semi-colon as a delim when in a windows
> environment, and colon in unix.
>
> Having multiple --searchpath flags on top of that is just extra sugar in my
> opinion.
>
> Just like the system path ...
>
>
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Jan 8, 2014 at 11:15 AM, Mark Koudritsky <kamrik@gmail.com> wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/16739/
> > -----------------------------------------------------------
> >
> > Review request for cordova.
> >
> >
> > Bugs: CB-5006
> >     https://issues.apache.org/jira/browse/CB-5006
> >
> >
> > Repository: cordova-plugman
> >
> >
> > Description
> > -------
> >
> > Same diff on github:
> > https://github.com/kamrik/cordova-plugman/compare/sp2
> >
> >
> > The colon can't be used as delimiter for Windows paths because
> > they already contain colons e.g. C:\my_plugins
> > Instead of using a delimiter, this change allows to repeat the
> > --searchpath flag for each additional directory to be searched.
> > The value for each path is resolved relative to the current dir.
> > Example:
> > --searchpath ../my_plugins --searhcpath /usr/lib/other_plugins
> >
> > The dirs are searched in order. Search is not recursive and will only
> > look one level down. It will look for
> > my_plugins/plugin_x/plugin.xml
> > but not for
> > my_plugins/bunch_of_plugins/plugin_y/plugin.xml
> >
> >
> > Diffs
> > -----
> >
> >   doc/help.txt 1ab3467
> >   main.js 877c563
> >   plugman.js 4c0f61b
> >
> > Diff: https://reviews.apache.org/r/16739/diff/
> >
> >
> > Testing
> > -------
> >
> > npm test
> > plugman (un)install
> >
> >
> > Thanks,
> >
> > Mark Koudritsky
> >
> >
>

--047d7b6d87ce4facc304ef7ad48b--