Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7737D10A26 for ; Mon, 13 Jan 2014 12:14:55 +0000 (UTC) Received: (qmail 45390 invoked by uid 500); 13 Jan 2014 12:03:22 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 45221 invoked by uid 500); 13 Jan 2014 12:02:49 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 44985 invoked by uid 99); 13 Jan 2014 12:01:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 12:01:44 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [63.245.216.69] (HELO smtp.mozilla.org) (63.245.216.69) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 12:01:39 +0000 Received: from [192.168.1.4] (das96.neoplus.adsl.tpnet.pl [83.23.18.96]) (Authenticated sender: pzalewa@mozilla.com) by mx1.mail.corp.phx1.mozilla.com (Postfix) with ESMTPSA id CB870F230D for ; Mon, 13 Jan 2014 04:01:17 -0800 (PST) Message-ID: <52D3D58A.3030905@mozilla.com> Date: Mon, 13 Jan 2014 13:01:14 +0100 From: Piotr Zalewa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: dev@cordova.apache.org Subject: Re: [Contacts] Should remove a missing contact be an error? References: <52AA2082.8010605@mozilla.com> <52B040AF.8030603@mozilla.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Thanks, I just implemented (by checking if the contact exists before calling remove) Piotr On 01/08/2014 01:54 AM, Steven Gill wrote: > Hey Piotr, > > I don't think their was any reason for going this route. Others can correct > me if I'm wrong. > > It comes down to if the developer should be/wants to be notified if a > contact they are removing exists or not. I'm sure use cases exist for both > options. > > I didn't find anything in the contact manager spec [1] about this specific > case. > > [1] > http://www.w3.org/TR/2013/WD-contacts-manager-api-20130307/#widl-ContactsManager-remove-ContactsRequest-Contact-contact > > > On Tue, Dec 17, 2013 at 4:16 AM, Piotr Zalewa wrote: > >> Is there any reason? >> >> >> On 12/12/2013 09:45 PM, Piotr Zalewa wrote: >> >>> Hi, >>> >>> I've been implementing Contacts API proxy on Firefox OS and been asked >>> if there is a reason for calling error callback on removing a non >>> existing contact. >>> >>> FFOS is calling success. >>> >>> Let mi quote Ben Kelly : >>> "Hmm, does the spec actually call this out as an error? I find success >>> in the "remove a non-existent entry" case more intuitive. The client >>> asked for the state where the DB does not contain X and open completion >>> the DB does not contain X. Whether any work is done is not really >>> relevant to the caller, is it?" >>> https://bugzilla.mozilla.org/show_bug.cgi?id=949575#c1 >>> >>> We might consider changing that behaviour in FFOS if there is a good >>> reason. >>> >>> Thanks >>> >> >> >> -- >> Piotr Zalewa >> Mozilla >> > -- Piotr Zalewa Mozilla