Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9711610580 for ; Tue, 21 Jan 2014 20:33:34 +0000 (UTC) Received: (qmail 74284 invoked by uid 500); 21 Jan 2014 20:33:34 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 74251 invoked by uid 500); 21 Jan 2014 20:33:33 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 74241 invoked by uid 99); 21 Jan 2014 20:33:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2014 20:33:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 910851D3E7E; Tue, 21 Jan 2014 20:33:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0949521008747173201==" MIME-Version: 1.0 Subject: Re: Review Request 17064: Add a CordovaError exception class for better error reporting in CLI From: "Andrew Grieve" To: "Andrew Grieve" , "Mark Koudritsky" , "cordova" Date: Tue, 21 Jan 2014 20:33:32 -0000 Message-ID: <20140121203332.28235.46485@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrew Grieve" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/17064/ X-Sender: "Andrew Grieve" References: <20140120220749.4981.60646@reviews.apache.org> In-Reply-To: <20140120220749.4981.60646@reviews.apache.org> Reply-To: "Andrew Grieve" X-ReviewRequest-Repository: cordova-cli --===============0949521008747173201== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17064/#review32417 ----------------------------------------------------------- Ship it! Merged! - Andrew Grieve On Jan. 20, 2014, 10:07 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17064/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 10:07 p.m.) > > > Review request for cordova. > > > Bugs: CB-5782 > https://issues.apache.org/jira/browse/CB-5782 > > > Repository: cordova-cli > > > Description > ------- > > The on('uncaughtException') handler was removed recently in cordova-cli because > it was hiding the stack traces of some legit exceptions, but this results in > scary traces for simple errors like running outside a corodva project. > > This change reintroduces the on('uncaughtException') handler and adds a special > CordovaError class for such simple errors. For exceptions of CordovaError class > only the message will be printed, for all other errors - the full stack trace. > > Another pass over the code will be needed to find and convert the Errors to > CordovaErrors where appropriate. Will be done in a separate change. > > > Diffs > ----- > > src/CordovaError.js PRE-CREATION > src/cli.js d22ba56 > src/util.js 278172a > > Diff: https://reviews.apache.org/r/17064/diff/ > > > Testing > ------- > > npm test > cordova plugin ls (inside and outside a a proj) > cordova bad_command > > > Thanks, > > Mark Koudritsky > > --===============0949521008747173201==--