Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8945810195 for ; Fri, 17 Jan 2014 19:06:52 +0000 (UTC) Received: (qmail 96455 invoked by uid 500); 17 Jan 2014 19:05:03 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 96433 invoked by uid 500); 17 Jan 2014 19:05:00 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 96305 invoked by uid 99); 17 Jan 2014 19:04:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 19:04:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2C5571D446A; Fri, 17 Jan 2014 19:04:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7679352933684182189==" MIME-Version: 1.0 Subject: Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare From: "Max Woghiren" To: "Mark Koudritsky" , "cordova" , "Max Woghiren" Date: Fri, 17 Jan 2014 19:04:46 -0000 Message-ID: <20140117190446.15506.91297@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Max Woghiren" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/16988/ X-Sender: "Max Woghiren" References: <20140116220345.12830.86227@reviews.apache.org> In-Reply-To: <20140116220345.12830.86227@reviews.apache.org> Reply-To: "Max Woghiren" X-ReviewRequest-Repository: cordova-plugman --===============7679352933684182189== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16988/#review32176 ----------------------------------------------------------- spec/util/config-changes.spec.js Is this function intentionally empty? - Max Woghiren On Jan. 16, 2014, 10:03 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16988/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 10:03 p.m.) > > > Review request for cordova. > > > Bugs: CB-5299 > https://issues.apache.org/jira/browse/CB-5299 > > > Repository: cordova-plugman > > > Description > ------- > > Same diff on github: https://github.com/kamrik/cordova-plugman/compare/fast_prepare > Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/ > > Parsing pbxproj is slow (~250ms on my machine). When running "cordova prepare" it is done for each plugin that needs to add frameworks to the ios project. This change is a quick and dirty fix to allow caching the parsed pbxproj object so that it can be reused for multiple plugins during prepare. Non ios projects are not affected. > > Sample timings for "cordova prepare ios" on a test project with 3 relevant plugins: > before: 1.623s > after: 0.981s > > > Diffs > ----- > > spec/util/config-changes.spec.js 795d825 > src/util/config-changes.js 2009f7f > > Diff: https://reviews.apache.org/r/16988/diff/ > > > Testing > ------- > > npm test > cordova prepare > cordova build > cordova create ... > > > Thanks, > > Mark Koudritsky > > --===============7679352933684182189==--