Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9753E105AF for ; Tue, 7 Jan 2014 22:52:38 +0000 (UTC) Received: (qmail 38650 invoked by uid 500); 7 Jan 2014 22:52:38 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 38626 invoked by uid 500); 7 Jan 2014 22:52:38 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 38616 invoked by uid 99); 7 Jan 2014 22:52:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jan 2014 22:52:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB7911D41A8; Tue, 7 Jan 2014 22:52:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3580122385412353590==" MIME-Version: 1.0 Subject: Re: Review Request 16701: Add --searchpath option for local plugin search path From: "Mark Koudritsky" To: "Mark Koudritsky" , "Braden Shepherdson" , "cordova" Date: Tue, 07 Jan 2014 22:52:37 -0000 Message-ID: <20140107225237.1150.44044@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Koudritsky" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/16701/ X-Sender: "Mark Koudritsky" References: <20140107214145.1151.95389@reviews.apache.org> In-Reply-To: <20140107214145.1151.95389@reviews.apache.org> Reply-To: "Mark Koudritsky" X-ReviewRequest-Repository: cordova-plugman --===============3580122385412353590== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16701/ ----------------------------------------------------------- (Updated Jan. 7, 2014, 10:52 p.m.) Review request for cordova. Changes ------- changed to return p.then(... pushed to github at https://github.com/kamrik/cordova-plugman/compare/searchpath Bugs: CB-5006 https://issues.apache.org/jira/browse/CB-5006 Repository: cordova-plugman Description ------- The diff here is missing author info and squashes 2 commits together, for properly formatted patch use: curl https://github.com/kamrik/cordova-plugman/compare/searchpath.patch | git am Add --searchpath option for local plugin search path. The param accepts a colon separated list of dirs that are searched in order for subdirs containing a plugin.xml file with the requested plugin ID. Diffs (updated) ----- doc/help.txt 0c6ad7a main.js 5fa6422 plugman.js a7ff484 src/fetch.js 0d50187 src/install.js 6b09434 Diff: https://reviews.apache.org/r/16701/diff/ Testing ------- npm test; plugman install --platform android --project /.../myproject/platforms/android --plugin org.apache.cordova.file plugman uninstall --platform android --project /.../myproject/platforms/android --plugin org.apache.cordova.file plugman install --platform android --project /.../myproject/platforms/android --plugin org.apache.cordova.file \ --searchpath /some_real/local_reg:/some/dummy/path cordova create MyApp cd MyApp cordova plugin add org.apache.cordova.file Thanks, Mark Koudritsky --===============3580122385412353590==--