cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anis KADRI <anis.ka...@gmail.com>
Subject Re: Review Request 16701: Add --searchpath option for local plugin search path
Date Wed, 08 Jan 2014 01:10:01 GMT
It doesn't hurt to have findLocalPlugin recursive. Does it? Some might
expect it (let's say if plugins are categorized into folders/sub-folders).
It doesn't hurt to comment on review board directly either.


On Tue, Jan 7, 2014 at 4:56 PM, Mark Koudritsky <kamrik@google.com> wrote:

> That's right, it will not recourse down the tree and will only look for
> plugin.xml one level down. It's easy to change it to walk the entire tree,
> but I'm not sure whether that's needed / wanted, would love some feedback
> on that.
>
>
>
>
>
> On Tue, Jan 7, 2014 at 6:36 PM, Josh Soref <jsoref@blackberry.com> wrote:
>
> > If I have:
> >
> > /tmp/world/A/b/plugin
> > /tmp/world/A/magic-pligin
> > /tmp/world/some-plugin
> >
> > And I try:
> > plugman install  --platform android --project
> > /.../myproject/platforms/android --plugin org.apache.cordova.file \
> >                   --searchpath /tmp/world
> >
> > Which directories are searched?
> >
> > It sounds like only some-plugin. I'm not saying that's wrong. I'm saying
> > that you are severely under - documenting what's expected and valid
> input.
> >
> > I should not have to guess. You should provide an example for everyone
> who
> > isn't you.
> > ---------------------------------------------------------------------
> > This transmission (including any attachments) may contain confidential
> > information, privileged material (including material protected by the
> > solicitor-client or other applicable privileges), or constitute
> non-public
> > information. Any use of this information by anyone other than the
> intended
> > recipient is prohibited. If you have received this transmission in error,
> > please immediately reply to the sender and delete this information from
> > your system. Use, dissemination, distribution, or reproduction of this
> > transmission by unintended recipients is not authorized and may be
> unlawful.
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message