cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Review Request 16701: Add --searchpath option for local plugin search path
Date Wed, 08 Jan 2014 15:01:39 GMT
Mark,

I think Jeff's point earlier was that he would like more documentation
about the behavior / limitations, not that he thinks your choices were
wrong.  Personally I would rather have explicit multiple search paths than
recursive search.  That way we are less likely to hit ambiguity with copies
existing in some subfolder and likely significantly faster operation in
certain scenarios.

-Michal


On Wed, Jan 8, 2014 at 9:41 AM, Mark Koudritsky <kamrik@google.com> wrote:

> Nope, right now neither will work. The multiple --searchpath options sound
> interesting, i'll check the possibility of using this instead of any
> delimiters so that it's platform independent. Thanks for pointing it out.
>
>
> On Wed, Jan 8, 2014 at 2:11 AM, Axel Nennker <ignisvulpis@gmail.com>
> wrote:
>
> > Have you thought of Windows paths?
> >
> > C:\myplugins; z:\sharedplugins
> >
> > Is the delimeter platform specific?
> > Can I have multiple searchpath parameters?
> >
> > --searchpath c:\myplugins --searchpath z:\sharedplugins
> >
> > --Axel
> > Am 07.01.2014 22:41 schrieb "Mark Koudritsky" <kamrik@gmail.com>:
> >
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/16701/
> > > -----------------------------------------------------------
> > >
> > > Review request for cordova.
> > >
> > >
> > > Bugs: CB-5006
> > >     https://issues.apache.org/jira/browse/CB-5006
> > >
> > >
> > > Repository: cordova-plugman
> > >
> > >
> > > Description
> > > -------
> > >
> > > The diff here is missing author info and squashes 2 commits together,
> for
> > > properly formatted patch use:
> > > curl
> https://github.com/kamrik/cordova-plugman/compare/searchpath.patch|
> > > git am
> > >
> > > Add --searchpath option for local plugin search path.
> > > The param accepts a colon separated list of dirs that are searched in
> > > order for subdirs containing a plugin.xml file with the requested
> plugin
> > ID.
> > >
> > >
> > > Diffs
> > > -----
> > >
> > >   doc/help.txt 0c6ad7a
> > >   main.js 5fa6422
> > >   plugman.js a7ff484
> > >   src/fetch.js 0d50187
> > >   src/install.js 6b09434
> > >
> > > Diff: https://reviews.apache.org/r/16701/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > npm test;
> > >
> > > plugman install   --platform android --project
> > > /.../myproject/platforms/android --plugin org.apache.cordova.file
> > > plugman uninstall --platform android --project
> > > /.../myproject/platforms/android --plugin org.apache.cordova.file
> > > plugman install   --platform android --project
> > > /.../myproject/platforms/android --plugin org.apache.cordova.file \
> > >                   --searchpath /some_real/local_reg:/some/dummy/path
> > >
> > > cordova create MyApp
> > > cd MyApp
> > > cordova plugin add org.apache.cordova.file
> > >
> > >
> > > Thanks,
> > >
> > > Mark Koudritsky
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message