cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Review Request 16854: Use plugin search path in cordova-cli
Date Tue, 14 Jan 2014 15:31:47 GMT
Took a look at the patch, looks good.  Seems you do some cleanup of plugin
handling at the same time, which is nice, but you may want to consider
splitting into two commits in case we want to revert just the search path
bit.


On Tue, Jan 14, 2014 at 10:29 AM, Michal Mocny <mmocny@chromium.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16854/
>
> Ship it!
>
> Ship It!
>
>
> - Michal Mocny
>
> On January 14th, 2014, 5:34 a.m. UTC, Mark Koudritsky wrote:
>   Review request for cordova.
> By Mark Koudritsky.
>
> *Updated Jan. 14, 2014, 5:34 a.m.*
>  *Bugs: * CB-5006 <https://issues.apache.org/jira/browse/CB-5006>
>  *Repository: * cordova-cli
> Description
>
> Same diff on github:https://github.com/kamrik/cordova-cli/compare/searchpath
>
> cordova plugin add will pass a plugin search path to plugman.
> The search path is read from .cordova/config.json and can also be provided on the command
line using --searchpath flag
> In order to store the search path in config.json, it can be passed as part of the object
with extra config to cordova create
>
> Examples:
> cordova plugin add org.apache.cordova.file --searchpath /some/dir/with/plugins
> cordova.raw.create(dir, appId, appName, {plugin_search_path: ['/path1', '/path2']} )
>
> Related plugman change: https://reviews.apache.org/r/16739/
>
>   Testing
>
> npm test
> cordova create
> cordova plugin add
>
>   Diffs
>
>    - spec/cli.spec.js (1a00002)
>    - src/cli.js (2375337)
>    - src/plugin.js (d0edf78)
>
> View Diff <https://reviews.apache.org/r/16854/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message