cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: template?
Date Fri, 03 Jan 2014 18:38:50 GMT
I'm all for this feature (and docs) but lets make it first class. Passing
the internal JSON representation feels like a leaky abstraction. The CLI
user should not know nor care about those internals and it would seem error
prone.


On Fri, Jan 3, 2014 at 9:24 AM, Mark Koudritsky <kamrik@google.com> wrote:

> > Well. I'm the one who "Fixed" this.
> >
> My bad, it's indeed Josh's
> change<
> https://github.com/kamrik/cordova-cli/commit/6490967289e5116b69ef33f1c0a81facdb92ac18
> >,
> sorry for getting confused about this, this was discussed at the time for a
> bit and I thought about doing the same but Josh did it before and also
> added the doc text to CLI help.
>
> Still, I think the better thing to do in this case is not to expose the 4th
> param of create() function to the CLI and leave it for internal (API) use
> only. This is similar to how some of the other cordova command fucntions
> take the "options" parameter that is created from the command line with
> some logic or by upstream tools that use the api. It would be nice to
> actually rename it to "options" for consistency.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message