cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Plugman optimizations
Date Fri, 24 Jan 2014 16:22:08 GMT
Hi Martin,

Thanks for the patch! Looks good from what I can tell. Before we can merge
it in though, we'll need to you sign Apache's contributor agreement, and
make sure that there's a Telerik one as well:
http://www.apache.org/licenses/#clas

Andrew


On Fri, Jan 24, 2014 at 3:20 AM, Martin Bektchiev <
Martin.Bektchiev@telerik.com> wrote:

> Hi guys,
>
> I have created a pull request for speeding up the process of adding
> multiple plugins to a Cordova project. This will speed up automated builds
> which create, set up and build a Cordova project from scratch. It turns out
> that currently the time needed to execute plugman numerous times for each
> of the required plugins is often comparable to the time taken by the build
> itself.
>
> First of all having to start the Node.JS process numerous times is itself
> a time consuming operation, so I enabled specifying multiple plugins at
> once by allowing repetition of the --plugin option as many times as is
> needed. This also opens the door for further caching and optimizations of
> slower operations.
>
> Then the second thing we noticed is that for iOS projects the most time
> consuming function was parseProjectFile, so I implemented a simple cache
> which allows for reusing its result for the same project file over and over
> again instead of reparsing it each time. This optimization alone speeded up
> the addition of 20 plugins more than 3 times.
>
> Can you please review and comment on the proposed changes at:
> https://github.com/apache/cordova-plugman/pull/45. The issue is logged
> here: https://issues.apache.org/jira/browse/CB-5885
>
> Thank you in advance!
>
> Best regards,
> Martin Bektchiev
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message