cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Moving .cordova/config.json -> cordova.json
Date Thu, 02 Jan 2014 17:27:12 GMT
currently, it's never written, but it is read when you do a "platform add"


On Thu, Jan 2, 2014 at 12:12 PM, Gorkem Ercan <gorkem.ercan@gmail.com>wrote:

> Are the platform locations set by Cordova CLI already? I know phonegap does
> it and I actually wish to add it to Cordova CLI as well [1] but I thought
> it was not implemented on CLI.
>
> [1] https://issues.apache.org/jira/browse/CB-5218
>
> In any case, engine info can go into cordova.xml.
> --
> Gorkem
>
>
> On Thu, Jan 2, 2014 at 10:22 AM, Andrew Grieve <agrieve@chromium.org>
> wrote:
>
> > What cordova.json has that config.xml doesn't, is that you can set the
> > location of platforms with it through:
> >
> > {
> >   "id":"org.apache.mobilespec",
> >   "name":"mobilespec",
> >   "lib": {
> >     "android": {
> >       "uri": "/Users/agrieve/git/cordova/cordova-android",
> >       "version": "dev",
> >       "id": "cordova-android-dev"
> >     },
> >     "ios": {
> >       "uri": "/Users/agrieve/git/cordova/cordova-ios",
> >       "version": "dev",
> >       "id": "cordova-ios-dev"
> >     }
> >   }
> > }
> >
> >
> > We're also planning on adding plugin search paths in there in
> > https://issues.apache.org/jira/browse/CB-5006.
> >
> > That said, I like your idea of having one top-level config file instead
> of
> > two. I don't see why we couldn't just put these same settings into a
> > "cordova.xml".
> >
> >
> >
> > On Wed, Jan 1, 2014 at 5:05 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> > wrote:
> >
> > > There is also another proposal to move config.xml out of www. Can we
> > merge
> > > this two moves and
> > > 1. remove .cordova
> > > 2. remove config.json
> > > 3. move config.xml to root
> > > 4. rename config.xml to cordova.xml
> > >
> > > AFAIK config,json does not carry any information that is not already
> > > available on the config.xml. Since .cordova is basically a marker for
> CLI
> > > for the root of an app I think renaming config.xml should provide the
> > same
> > > functionality.
> > > --
> > > Gorkem
> > >
> > >
> > >
> > >
> > > On Tue, Dec 31, 2013 at 1:19 PM, Andrew Grieve <agrieve@chromium.org>
> > > wrote:
> > >
> > > > Thanks for the feedback!
> > > >
> > > > I don't think we should move files around automatically because it
> > could
> > > > mess with people's source control.
> > > >
> > > > I think using old versions of CLI with newer projects can't be
> > supported,
> > > > but we can certainly (and I think have been) supporting using newer
> > > > versions of CLI with older projects.
> > > >
> > > > Searching up until you find a cordova.json (or .cordova) sounds like
> a
> > > good
> > > > way to find the root.
> > > >
> > > >
> > > >
> > > > On Mon, Dec 30, 2013 at 5:46 PM, Dick Van den Brink <
> > > > d_vandenbrink@outlook.com> wrote:
> > > >
> > > > > CLI searches for the .cordova folder from the current working
> > directory
> > > > up
> > > > > to the root. What will be the new approach? Searching for the
> > > > cordova.json
> > > > > and .cordova for compatibility?
> > > > >
> > > > >
> > > > > While I do agree on the change I don't really like the if folder
> > exists
> > > > or
> > > > > config exists approach thingy, can't we do something with the
> upgrade
> > > > > command to move the files around where we want them and just force
> > the
> > > > new
> > > > > way? Not sure if this is an ideal approach.. but yeah…
> > > > >
> > > > >
> > > > > I know this makes it really important to use the right cli version
> on
> > > the
> > > > > projects but I don't believe a new cli with old project structure
> or
> > > the
> > > > > old cli with new platform versions work now because of the
> > differences
> > > > > where Cordova.js is stored for example.. So I don't think that's
a
> > real
> > > > > issue.
> > > > >
> > > > >
> > > > > What do you guys think? Or am I talking nonsense right now?
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > Verzonden met Windows Mail
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > Van: Andrew Grieve
> > > > > Verzonden: maandag 30 december 2013 22:08
> > > > > Aan: dev@cordova.apache.org
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > Proposal:
> > > > > For CLI projects:
> > > > > - Use ./cordova.json if it exists, otherwise use
> .cordova/config.json
> > > > > - Use ./hooks/* if it exists, otherwise use .cordova/hooks/*
> > > > > - Change the project template to use ./cordova.json instead of
> > > > > .cordova/config.json
> > > > >
> > > > >
> > > > > Reasons:
> > > > > - We want users to put .cordova into source control, so shouldn't
> > hide
> > > it
> > > > > - We didn't make plugins/ and platforms/ hidden, so shouldn't hide
> > > > > .cordova/
> > > > >
> > > > >
> > > > > Sound good? If so I'll make an issue and work on this. Since it's
> > > > holidays,
> > > > > will wait until next week Tuesday (Jan 7) to proceed.
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message