cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Zalewa <pzal...@mozilla.com>
Subject Re: [Contacts] Should remove a missing contact be an error?
Date Mon, 13 Jan 2014 12:01:14 GMT
Thanks,

I just implemented (by checking if the contact exists before calling remove)

Piotr

On 01/08/2014 01:54 AM, Steven Gill wrote:
> Hey Piotr,
>
> I don't think their was any reason for going this route. Others can correct
> me if I'm wrong.
>
> It comes down to if the developer should be/wants to be notified if a
> contact they are removing exists or not. I'm sure use cases exist for both
> options.
>
> I didn't find anything in the contact manager spec [1] about this specific
> case.
>
> [1]
> http://www.w3.org/TR/2013/WD-contacts-manager-api-20130307/#widl-ContactsManager-remove-ContactsRequest-Contact-contact
>
>
> On Tue, Dec 17, 2013 at 4:16 AM, Piotr Zalewa <pzalewa@mozilla.com> wrote:
>
>> Is there any reason?
>>
>>
>> On 12/12/2013 09:45 PM, Piotr Zalewa wrote:
>>
>>> Hi,
>>>
>>> I've been implementing Contacts API proxy on Firefox OS and been asked
>>> if there is a reason for calling error callback on removing a non
>>> existing contact.
>>>
>>> FFOS is calling success.
>>>
>>> Let mi quote Ben Kelly :
>>> "Hmm, does the spec actually call this out as an error?  I find success
>>> in the "remove a non-existent entry" case more intuitive.  The client
>>> asked for the state where the DB does not contain X and open completion
>>> the DB does not contain X.  Whether any work is done is not really
>>> relevant to the caller, is it?"
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=949575#c1
>>>
>>> We might consider changing that behaviour in FFOS if there is a good
>>> reason.
>>>
>>> Thanks
>>>
>>
>>
>> --
>> Piotr Zalewa
>> Mozilla
>>
>


-- 
Piotr Zalewa
Mozilla

Mime
View raw message