cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Re: Review Request 17553: Throw when trying to create project inside custom www dir
Date Thu, 30 Jan 2014 21:37:10 GMT


> On Jan. 30, 2014, 8:12 p.m., Ian Clelland wrote:
> > src/create.js, line 93
> > <https://reviews.apache.org/r/17553/diff/1/?file=456713#file456713line93>
> >
> >     Does this take into account the situation where config_json.lib.www is a relative
path?
> >

Good point. Added path.resolve()
It's not completely clear whether the resolve should be relative to CWD or relative to project
path. But since in this case --souce is usually passed from the command line it's likely to
be relative to CWD.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17553/#review33246
-----------------------------------------------------------


On Jan. 30, 2014, 9:37 p.m., Mark Koudritsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17553/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 9:37 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5947
>     https://issues.apache.org/jira/browse/CB-5947
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> If a custom www dir is provided and is a parent or the same as the project dir, cordova
create fails while trying to create an infinite file hierarchy. Detect and stop in this case.
> 
> 
> Diffs
> -----
> 
>   src/create.js 75b2621 
> 
> Diff: https://reviews.apache.org/r/17553/diff/
> 
> 
> Testing
> -------
> 
> npm test
> cordova create --srouce ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message