cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <>
Subject Re: Review Request 17064: Add a CordovaError exception class for better error reporting in CLI
Date Mon, 20 Jan 2014 21:23:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 20, 2014, 9:23 p.m.)

Review request for cordova.


 - Move CordovaError to CordovaError.js
 - Move prototype assignment outside of the constructor. 

Bugs: CB-5782

Repository: cordova-cli


The on('uncaughtException') handler was removed recently in cordova-cli because
it was hiding the stack traces of some legit exceptions, but this results in
scary traces for simple errors like running outside a corodva project.

This change reintroduces the on('uncaughtException') handler and adds a special
CordovaError class for such simple errors. For exceptions of CordovaError class
only the message will be printed, for all other errors - the full stack trace.

Another pass over the code will be needed to find and convert the Errors to
CordovaErrors where appropriate. Will be done in a separate change.

Diffs (updated)

  src/CordovaError.js PRE-CREATION 
  src/cli.js d22ba56 
  src/util.js 278172a 



npm test
cordova plugin ls (inside and outside a a proj)
cordova bad_command


Mark Koudritsky

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message