cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <>
Subject Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare
Date Fri, 17 Jan 2014 19:11:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 17, 2014, 7:11 p.m.)

Review request for cordova.


Added caching in config-changes.process() where it calls add_plugin_changes()

Bugs: CB-5299

Repository: cordova-plugman


Same diff on github:
Corresponding change in cordova-cli:

Parsing pbxproj is slow (~250ms on my machine). When running "cordova prepare" it is done
for each plugin that needs to add frameworks to the ios project. This change is a quick and
dirty fix to allow caching the parsed pbxproj object so that it can be reused for multiple
plugins during prepare. Non ios projects are not affected.

Sample timings for "cordova prepare ios" on a test project with 3 relevant plugins:
before: 1.623s
after:  0.981s

Diffs (updated)

  spec/util/config-changes.spec.js 795d825 
  src/util/config-changes.js 2009f7f 



npm test
cordova prepare 
cordova build
cordova create ...


Mark Koudritsky

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message