cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare
Date Thu, 16 Jan 2014 22:03:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/
-----------------------------------------------------------

Review request for cordova.


Bugs: CB-5299
    https://issues.apache.org/jira/browse/CB-5299


Repository: cordova-plugman


Description
-------

Same diff on github: https://github.com/kamrik/cordova-plugman/compare/fast_prepare
Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/

Parsing pbxproj is slow (~250ms on my machine). When running "cordova prepare" it is done
for each plugin that needs to add frameworks to the ios project. This change is a quick and
dirty fix to allow caching the parsed pbxproj object so that it can be reused for multiple
plugins during prepare. Non ios projects are not affected.

Sample timings for "cordova prepare ios" on a test project with 3 relevant plugins:
before: 1.623s
after:  0.981s


Diffs
-----

  spec/util/config-changes.spec.js 795d825 
  src/util/config-changes.js 2009f7f 

Diff: https://reviews.apache.org/r/16988/diff/


Testing
-------

npm test
cordova prepare 
cordova build
cordova create ...


Thanks,

Mark Koudritsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message