cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve" <agri...@chromium.org>
Subject Re: Review Request 16739: Change --searchpath to use repeated flag instead of delimiter
Date Tue, 14 Jan 2014 16:19:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16739/#review31729
-----------------------------------------------------------

Ship it!


Merged!

- Andrew Grieve


On Jan. 14, 2014, 5:33 a.m., Mark Koudritsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16739/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 5:33 a.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5006
>     https://issues.apache.org/jira/browse/CB-5006
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> -------
> 
> Same diff on github:
> https://github.com/kamrik/cordova-plugman/compare/sp2
> 
>     
> The colon can't be used as delimiter for Windows paths because 
> they already contain colons e.g. C:\my_plugins
> Instead of using a delimiter, this change allows to repeat the
> --searchpath flag for each additional directory to be searched.
> The value for each path is resolved relative to the current dir.
> Example:
> --searchpath ../my_plugins --searhcpath /usr/lib/other_plugins
> 
> The dirs are searched in order. Search is not recursive and will only
> look one level down. It will look for
> my_plugins/plugin_x/plugin.xml
> but not for
> my_plugins/bunch_of_plugins/plugin_y/plugin.xml    
> 
> 
> Diffs
> -----
> 
>   doc/help.txt 1ab3467 
>   main.js 877c563 
>   plugman.js 4c0f61b 
>   src/fetch.js 2f45f5f 
> 
> Diff: https://reviews.apache.org/r/16739/diff/
> 
> 
> Testing
> -------
> 
> npm test
> plugman (un)install 
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message