Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: Josh Soref <jsoref@blackberry.com>
To: Cordova Dev <dev@cordova.apache.org>
Subject: Re: [Node 101] Part 2: Avoid the Triangle of Doom
Thread-Topic: [Node 101] Part 2: Avoid the Triangle of Doom
Thread-Index: AQHO94+Flr3VzNrMDkSFPWs6hxz/CJpRODyA
Date: Thu, 12 Dec 2013 23:41:07 +0000
Message-ID: <CECFB394.78D7%jsoref@blackberry.com>
References: 
 <CADVgkyMAfpRghWzOJCJgkWYEdAjmJJ4NeKAXvgLbq1xE4fv9=g@mail.gmail.com>
In-Reply-To: 
 <CADVgkyMAfpRghWzOJCJgkWYEdAjmJJ4NeKAXvgLbq1xE4fv9=g@mail.gmail.com>
Accept-Language: en-US, en-CA
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.9.131030
Content-ID: <3E389AE24A7FDA4297FE9638D20BA783@rim.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable

Brian wrote:
>Flatten your async code. New fashion advocates promises, generators,
>events, or one of the streams apis.

While flattening with promises is great=8A
 =


>The classic method is to write small testable modules (see part 1) and
>flatten your tree.
>
>Turn code that looks like this [1] into this [2].

=8A I can=B9t figure out how your two example blobs relate.

For the sake of people trying to learn patterns, can you please ensure
that your [1] and [2] are obvious =B3before=B2 and =B3after=B2?

>[1]
>https://github.com/apache/cordova-js/blob/b75096a1bade9ca6aa0d38a2039fd922
>ad7c1a95/test/runner.js#L99-L136
>[2]
>https://github.com/apache/cordova-js/blob/ced04a4ec71f144dd2cd6c2e9392e3b1
>fc725ec1/tasks/lib/test-browser.js

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential info=
rmation, privileged material (including material protected by the solicitor=
-client or other applicable privileges), or constitute non-public informati=
on. Any use of this information by anyone other than the intended recipient=
 is prohibited. If you have received this transmission in error, please imm=
ediately reply to the sender and delete this information from your system. =
Use, dissemination, distribution, or reproduction of this transmission by u=
nintended recipients is not authorized and may be unlawful.