Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 115961076D for ; Tue, 3 Dec 2013 22:53:22 +0000 (UTC) Received: (qmail 36228 invoked by uid 500); 3 Dec 2013 22:53:21 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 36195 invoked by uid 500); 3 Dec 2013 22:53:21 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 36182 invoked by uid 99); 3 Dec 2013 22:53:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2013 22:53:21 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ignisvulpis@gmail.com designates 209.85.128.182 as permitted sender) Received: from [209.85.128.182] (HELO mail-ve0-f182.google.com) (209.85.128.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2013 22:53:18 +0000 Received: by mail-ve0-f182.google.com with SMTP id jy13so11371471veb.27 for ; Tue, 03 Dec 2013 14:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=vVmnNuVfITU0Wo/N5lunCl5OuA4Sn0Ad0lGOZhvlkWc=; b=zycFBCUgLxgJ+D8I0wYT6GtyB0q6J0GMUEwIOwmIKZWxiDr/QTvG1oSZLkVdW1WiP/ DCLEOyk1QVNQt7HUUzUdof5HKbEHRe8u6/ObN/RkPXrtzeFeYDIu8dvPUVH1QzN7snaT 877I+HckRLF6M1e6q7ImMZEtQntP+87tbR7nk9lCQKxfnKSs+4sXUKJDY91EigEXmIql s2QbU9S7xEEXjD2hlTwQaww4TAHJEHA59nRXZpdsrYDuN/XZWXmSTpoT1M69jSpgSv90 wIBQULZD5AJPyO+m9Qqta5Tq0R/qNsdLTxpVptYdha0vXLTla2mM774v4jgbZi6/cDTK hXKQ== MIME-Version: 1.0 X-Received: by 10.220.186.202 with SMTP id ct10mr58438291vcb.14.1386111177124; Tue, 03 Dec 2013 14:52:57 -0800 (PST) Received: by 10.220.171.200 with HTTP; Tue, 3 Dec 2013 14:52:56 -0800 (PST) In-Reply-To: References: Date: Tue, 3 Dec 2013 23:52:56 +0100 Message-ID: Subject: Re: PluginEntry.java crash in getClassByName From: Axel Nennker To: dev@cordova.apache.org, bowserj@apache.org Content-Type: multipart/alternative; boundary=047d7b676fd055211b04eca928b2 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b676fd055211b04eca928b2 Content-Type: text/plain; charset=ISO-8859-1 Pull request is here: https://github.com/apache/cordova-android/pull/87 I took the easier path to check for the empty string in PluginEntry.java instead of trying to find out what other effects a change in PluginManager.java from "" to null might have. Axel 2013/12/3 Axel Nennker > done: > https://issues.apache.org/jira/browse/CB-5537 > > > > 2013/12/3 Joe Bowser > >> Can you please create an issue so that this is tracked? >> >> On Tue, Dec 3, 2013 at 11:02 AM, wrote: >> > Hi, >> > >> > I don't know why or since when but getClassByName is called with an >> argument >> > of "" (not null). >> > >> > The method getClassByName checks for null but not for "" and so it >> crashes. >> > >> > This happens for the service http://api.phonegap.com/1.0/device >> > >> > I am using cordova-3.1.0-0.2.0 >> > >> > A screenshot of the debugging window is attached. >> > >> > A simple fix seems to be to never set this.pluginClass in >> PluginEntry.java >> > to "" but to null. PluginManager.java contains the assignment: >> pluginClass = >> > "" >> > >> > >> > >> > -Axel >> > >> > >> > > --047d7b676fd055211b04eca928b2--