Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EAC31094E for ; Tue, 10 Dec 2013 03:55:19 +0000 (UTC) Received: (qmail 38224 invoked by uid 500); 10 Dec 2013 03:55:14 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 38122 invoked by uid 500); 10 Dec 2013 03:55:11 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 38096 invoked by uid 99); 10 Dec 2013 03:55:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Dec 2013 03:55:09 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates 209.85.192.175 as permitted sender) Received: from [209.85.192.175] (HELO mail-pd0-f175.google.com) (209.85.192.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Dec 2013 03:55:03 +0000 Received: by mail-pd0-f175.google.com with SMTP id w10so6461818pde.34 for ; Mon, 09 Dec 2013 19:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=WC2nHVIt3pa7cJtP8CYtzWppoUw2CJoBfMFJ/3Nst0Q=; b=BGC6oilLpMk5Kdl7F5GQ8LokDCdRYXgI0/A6oAxYYdbRW5UBxQ22x3Rbd9MfXUr241 /Vz2BtzmCyMyT1lJfO07c6JWf71CK/XFgY4wchLP8Nx791/ZM9Mb08r3/Oomc/Mz9uUX oHV4prvM5eOxbPIV9h4k46MRG9vb+bsv8mZ7P8kugJY9B8aLufXhwMzRbRQvExzIvfoC B+zLpp3cknpHY3pw+kr2sTcp73tIlXv8OfKqVk0YFmN7HXQSfwG2/nO1OwOuMzundTNx WGnQxQ6jCsuRA3m+9ByIj1TTIOBO/VXjyFqzaj2jOU59oHlN4GniiZHEFmN5tk3zSHzj YLGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=WC2nHVIt3pa7cJtP8CYtzWppoUw2CJoBfMFJ/3Nst0Q=; b=ZvJFS7nxUuGj8C3sHeRu9YF9fVQuVl5XraKNpN+CV4D06XIK60O0LfVRNRzYqmroxb Jwy9TSvJLD0SLMJT66YIZQ+Z22NVDs5FT89RBNdWTv/pQomLjE+aSVwtf8jLgcOoJMI4 4KCaGgvYTBTmwPe0L7lZXBQY7hH700Q0aYplQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=WC2nHVIt3pa7cJtP8CYtzWppoUw2CJoBfMFJ/3Nst0Q=; b=GnPL2NKQF6taYgbiWvPXNLrYXFReD9xh1sHIvqKsISz/dhLq5NFYJm4DbwPGh5I/zf b02p8a1i+JT2fxV0uUC9V9o/27oDouw/uDyEmxek3bmTITXYP7698sKKgnDRQv2whVsz ghu4fpwlhJg1R5u/fqyV0xCIfShbneQuJWKNSG9xJi2hxueD7ftqrQd8emuuB7xxsKuP Mgz7uzgT30QA61xN06DPrGKzDVSkVEB0H92lWrlHZKz4GreCt+srY3mbhb+VaPj7sSoP 0ih4Q5BZ1WQxHtrkVeZwPkfBXgvVqhVmVelrC9S9pYxqha7UfFFcbyqj4ydq6U9pKJ3s cE4g== X-Gm-Message-State: ALoCoQkxhlKz//d97CUg4gcP65+8VIEDFq4/+kg3Nx+Zu1UmjiOlkbT7wOkOn4VZ0O1hAftnxrlsTT5AHmtZg/75T2qCC8sHfdiCG0qEsKymlBMD7LXZ+988dSq2iNQAiJCU3ngGLPtompGfEX9snx6sitSYbn/iJvCH+mRTHuRhuj8Td1dPyI4pTD1lXViLuWWslqyfAhbJP9jc5r205H1wRKs+QX/zvA== X-Received: by 10.66.161.1 with SMTP id xo1mr8679367pab.146.1386647682398; Mon, 09 Dec 2013 19:54:42 -0800 (PST) MIME-Version: 1.0 Sender: agrieve@google.com Received: by 10.68.136.35 with HTTP; Mon, 9 Dec 2013 19:54:21 -0800 (PST) In-Reply-To: References: From: Andrew Grieve Date: Mon, 9 Dec 2013 22:54:21 -0500 X-Google-Sender-Auth: IVo_jZow36orBWA8TtHSd24gxds Message-ID: Subject: Re: mocking in cordova.js To: dev Content-Type: multipart/alternative; boundary=047d7b86c2ca89d43304ed261218 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b86c2ca89d43304ed261218 Content-Type: text/plain; charset=ISO-8859-1 I'd be fine with PhantomJS. I had to not add a unit test to urlutil that I wanted to because jsdom didn't emulate things quite right. On Mon, Dec 9, 2013 at 9:14 PM, Brian LeRoux wrote: > Where would I add a mock for XMLHttpRequest? > > https://github.com/apache/cordova-js/pull/60/files > > (Also: would you guys be cool w/ me refactoring cordova.js to use PhantomJS > instead of jsdom?) > --047d7b86c2ca89d43304ed261218--