Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.192.178 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <05cdf53f5d724b9e98f67a8b6f2f3804@BL2PR03MB417.namprd03.prod.outlook.com>
References: 
 <CAK_TSXJejh6jC=KiSrYaJd8DtOn3frg3Ah2kYYCt5yDhqEyhbQ@mail.gmail.com>
 <9bc28c5131fb4eb7a8eb4595902e8a06@BL2PR03MB338.namprd03.prod.outlook.com>
 <CAK_TSXJ5QiAhLmsNo07dzzYt=1M1DbLf2NdPW8iVhQtjouMg1A@mail.gmail.com>
 <CAKP6k2ujhMpRvULTPh+0qjNYU=V92Q4TMo9Mu3VypQda3mX0YA@mail.gmail.com>
 <311af38e5ccb4e4b9e29237622d531f9@DM2PR03MB366.namprd03.prod.outlook.com>
 <5a192c7c5bcb4355a713f07bb2706211@BL2PR03MB417.namprd03.prod.outlook.com>
 <CAEeF2Tdze+qOOc5rbzimQRnBAje4E3EMYObp=4xoS-xPMWvV-Q@mail.gmail.com>
 <CAK_TSXJ+1Zi2xWq8VCGqRu65GxZbM2=13NJ03nf6=V2gf0-q3g@mail.gmail.com>
 <05cdf53f5d724b9e98f67a8b6f2f3804@BL2PR03MB417.namprd03.prod.outlook.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Wed, 18 Dec 2013 10:01:07 -0500
Message-ID: 
 <CABiQX1XCkU8wBtDkfZtk3ofxu99YPFAtuyVPf0aB98BEK9cAiw@mail.gmail.com>
Subject: Re: Windows Phone binary bridge
To: dev <dev@cordova.apache.org>, iclelland <iclelland@chromium.org>
Content-Type: multipart/alternative; boundary=bcaec520e8f5c7c97904edd0519c

--bcaec520e8f5c7c97904edd0519c
Content-Type: text/plain; charset=UTF-8

Neat! Just played with it in Chrome and FileReader certainly does seem
faster.

Ian's on a side project this week, but he spent a good amount of time
figuring out the fastest way to do this conversion when he added that in,
so I'm sure he'll have a look.


On Wed, Dec 18, 2013 at 6:42 AM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:

> Does anyone see this interesting? Any real cases where it could be
> important?
>
> Thx!
> Sergey
> -----Original Message-----
> From: Sergey Grebnov (Akvelon)
> Sent: Wednesday, December 11, 2013 8:33 PM
> To: 'dev@cordova.apache.org'
> Subject: RE: Windows Phone binary bridge
>
> I've just compared ArrayBuffer to string conversion time via currently
> used base64 method and via blob reading and the second one runs faster (2-4
> times on WP8 HTC 8S and 7-10 times faster on iPhone5; don't have Android
> device to test).
>
> So in case browser natively support FileReader and Blob api we may want to
> use that method.
>
> Here is test page I use
> http://goo.gl/5mpjYu
> http://sgrebnov.github.io/tmp/binPerfTest/www/js/index.js
>
> testBase64Str: function(data) {
>          var defer = Q.defer();
>         defer.resolve(base64.fromArrayBuffer(data));
>
>         return defer.promise;
>     },
>
> testBlobReader: function(data) {
>         var defer = Q.defer(),
>             blob = new Blob([data]),
>             reader = new FileReader();
>
>         reader.onloadend = function(e) {
>             defer.resolve(e.target.result);
>         }
>         reader.readAsText(blob, "UTF-8");
>         return defer.promise;
>     },
>
>
> Thx!
> Sergey
> -----Original Message-----
> From: Sergey Grebnov (Akvelon)
> Sent: Monday, December 9, 2013 9:36 PM
> To: dev@cordova.apache.org
> Subject: RE: Windows Phone binary bridge
>
> I see.. I've added similar logic to windows phone exec bridge
> https://github.com/apache/cordova-js/pull/59
>
> Tested on File Api, below  is updated version after patching wp bridge
> https://github.com/apache/cordova-plugin-file/pull/18
>
> PS. As showed at [1] manual array manipulation is not the fastest solution
> but it is the most convenient synchronous one [1]
> http://updates.html5rocks.com/2012/06/How-to-convert-ArrayBuffer-to-and-from-String
>
> Thx!
> Sergey
> -----Original Message-----
> From: iclelland@google.com [mailto:iclelland@google.com] On Behalf Of Ian
> Clelland
> Sent: Monday, December 9, 2013 9:06 PM
> To: dev@cordova.apache.org
> Subject: Re: Windows Phone binary bridge
>
> Yes, we used to use that; I had to switch it to use a base64-encoding
> method; Using Array.prototype.apply() literally pushes every element of the
> array individually onto the stack as a separate argument. The exact limit
> depends on the device, but eventually they all fail with a "Stack
> exploded"-sort-of-exception.
>
> Ian
>
>
> On Mon, Dec 9, 2013 at 10:32 AM, Michal Mocny <mmocny@chromium.org> wrote:
>
> > Where do you see an implementation using Array.apply(null, new
> > Uint8Array(...)) ?
> >
> > We used to have this bug in ios/android binary bridge but that was
> > patched many releases ago (unless there is a stray one somewhere that
> > still needs fixing).
> >
> >
> > On Mon, Dec 9, 2013 at 10:15 AM, Sergey Grebnov (Akvelon) <
> > v-segreb@microsoft.com> wrote:
> >
> > > Working on this...I just found out that current implementation via
> > > Array.apply(null, new Uint8Array(...)) doesn't work for big buffers
> > (bigger
> > > than 150Kb) and could raise Maximum call stack size exceeded error.
> > > So
> > I'm
> > > looking on better/right way to do typed arrays conversion... will
> > > keep
> > you
> > > updated.
> > >
> > > Thx!
> > > Sergey
> > > -----Original Message-----
> > > From: Parashuram Narasimhan (MS OPEN TECH) [mailto:
> > panarasi@microsoft.com]
> > > Sent: Saturday, December 7, 2013 1:52 AM
> > > To: dev@cordova.apache.org
> > > Subject: RE: Windows Phone binary bridge
> > >
> > > I think Sergey should be able to squeeze this into his schedule. We
> > > were looking at fixing plugin support and this could be a good way
> > > to start
> > it.
> > >
> > > -----Original Message-----
> > > From: Jesse [mailto:purplecabbage@gmail.com]
> > > Sent: Friday, December 6, 2013 1:30 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: Windows Phone binary bridge
> > >
> > > FYI, you can buy a no contract Nokia 520 WP8 device for $120, and
> > > developing in the emulator is more than sufficient for most tasks.
> > >
> > > Sergey, do you got this?
> > >
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Fri, Dec 6, 2013 at 11:21 AM, Ian Clelland
> > > <iclelland@chromium.org
> > > >wrote:
> > >
> > > > On Fri, Dec 6, 2013 at 2:15 PM, Sergey Grebnov (Akvelon) <
> > > > v-segreb@microsoft.com> wrote:
> > > >
> > > > > Agree and  like this idea. I don't think there are many other
> > > > > components (if any) which use ArrayBuffer but must be tested
> > > > > well anyway since this changes core. Ian do you want to complete
> > > > > this yourself or you are ok if
> > > > I
> > > > > handle this?
> > > > >
> > > >
> > > > I'm totally okay with you doing it -- I don't have a real windows
> > > > phone device to test it on; I'd be committing with my eyes closed
> > > > and hoping for the best :)
> > > >
> > > > I think you're right that there aren't any other core plugins
> > > > using the binary bridge, but that could change, and there are
> > > > probably already third-party plugins using it.
> > > >
> > > > If we do this right, then other developers won't have to roll
> > > > their own solution in each case, and it will be easier to port the
> > > > third-party plugins to WP.
> > > >
> > > > Let me know if you need any support; I'll help if I can.
> > > >
> > > > Ian
> > > >
> > > >
> > > > >
> > > > > -Sergey
> > > > > -----Original Message-----
> > > > > From: iclelland@google.com [mailto:iclelland@google.com] On
> > > > > Behalf Of
> > > > Ian
> > > > > Clelland
> > > > > Sent: Friday, December 6, 2013 7:37 PM
> > > > > To: dev@cordova.apache.org
> > > > > Subject: Windows Phone binary bridge
> > > > >
> > > > > As far as I can tell from reading its exec.js, WP8 does not have
> > > > > a binary bridge of any kind. Non-string data get JSON-serialized
> > > > > for
> > > transfer.
> > > > >
> > > > > The recent patch for CB-5532 broke the File plugin by explicitly
> > > > > casting ArrayBuffer data to Array type. Sergey's fixed it now,
> > > > > but the FileWriter JS code still has special cases for Windows
> > > > > and WP8
> > > platforms.
> > > > >
> > > > > Would it make sense to have this code moved into the WP8 exec
> bridge?
> > > > Then
> > > > > it could apply to any plugins which transfer binary data, and
> > > > > any
> > > > improved
> > > > > transport methods would automatically be used by all plugins,
> > > > > rather than being a special case in each plugin.
> > > > >
> > > > > I don't know much about the Windows phone platform, so I could
> > > > > be completely off-base about this, but if it works, I think
> > > > > it'll make the implementation cleaner, and generally make
> > > > > Cordova better on the
> > > > platform.
> > > > >
> > > > > Ian
> > > > >
> > > >
> > >
> >
>

--bcaec520e8f5c7c97904edd0519c--