Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.160.46 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CADVgkyNV1XzY3irxNuZ74EH4pZUd=kphMq4kEam+dekVrEALFQ@mail.gmail.com>
References: 
 <CADVgkyNV1XzY3irxNuZ74EH4pZUd=kphMq4kEam+dekVrEALFQ@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Wed, 11 Dec 2013 09:57:23 -0500
Message-ID: 
 <CABiQX1X5D+8u_y-_-HzMLwphPqkMG7etWV50tXVHGb9TPgcXOg@mail.gmail.com>
Subject: Re: review request for cordova-js gruntfile refactor
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b3a9b8e83fdfb04ed4373b0

--047d7b3a9b8e83fdfb04ed4373b0
Content-Type: text/plain; charset=ISO-8859-1

Brian - the 8 commits change is pretty overwhelming to look at all at once.
Could you split them up into those that you want looked at, and those that
you don't (e.g. lib->src & splitting gruntfile into separate files don't
really need to be looked at).


On Tue, Dec 10, 2013 at 11:04 PM, Brian LeRoux <b@brian.io> wrote:

> https://github.com/apache/cordova-js/pull/61
>
> In my quest to add the browser platform I got a little sidetracked cleaning
> up the gruntfile. Please have a look. The _btest fails currently but I
> think I want to move to phantom anyhow. Otherwise everything is identical.
>

--047d7b3a9b8e83fdfb04ed4373b0--