Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EA2010746 for ; Thu, 12 Dec 2013 21:27:06 +0000 (UTC) Received: (qmail 44535 invoked by uid 500); 12 Dec 2013 21:27:06 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 44507 invoked by uid 500); 12 Dec 2013 21:27:06 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 44497 invoked by uid 99); 12 Dec 2013 21:27:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Dec 2013 21:27:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ED7A01D3D9C; Thu, 12 Dec 2013 21:27:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4873158548289205146==" MIME-Version: 1.0 Subject: Re: Review Request 15775: Add --src & --link to "cordova create" From: "Mark Koudritsky" To: "Mark Koudritsky" , "Ian Clelland" , "cordova" Date: Thu, 12 Dec 2013 21:27:04 -0000 Message-ID: <20131212212704.23250.94666@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Koudritsky" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/15775/ X-Sender: "Mark Koudritsky" References: <20131129165551.31509.6478@reviews.apache.org> In-Reply-To: <20131129165551.31509.6478@reviews.apache.org> Reply-To: "Mark Koudritsky" X-ReviewRequest-Repository: cordova-cli --===============4873158548289205146== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/ ----------------------------------------------------------- (Updated Dec. 12, 2013, 9:27 p.m.) Review request for cordova. Changes ------- --link was a boolean before, now it accepts a path, so it's either --src=path or --link=path. Added a check in config_parser to make sure we are looking at an xml file that looks like Cordova config.xml to avoid overwriting some unrelated config.xml when symlinking to www dir. Same diff on github: https://github.com/kamrik/cordova-cli/compare/src_www Bugs: CB-4153 https://issues.apache.org/jira/browse/CB-4153 Repository: cordova-cli Description ------- Add --src & --link to "cordova create". Both --src and --source are accepted. The path is passed via the lib.www.uri of the configuration object that is later written to .cordova/config.json. Cordova will keep going into child www folder(s) of the provided path. Diffs (updated) ----- doc/help.txt 3361dd3 e2e/create.spec.js 560f82a spec/metadata/android_parser.spec.js 52fc78a spec/metadata/ios_parser.spec.js b56ddce spec/metadata/windows8_parser.spec.js 5117148 spec/metadata/wp7_parser.spec.js 6dc0695 spec/metadata/wp8_parser.spec.js 8cd1923 src/cli.js 2916062 src/config_parser.js b6293d8 src/create.js 961d787 src/metadata/wp8_parser.js 163d56b Diff: https://reviews.apache.org/r/15775/diff/ Testing ------- npm test; cordova -d create TstApp --source=some/www --link a bunch of other cordova commands in the app Thanks, Mark Koudritsky --===============4873158548289205146==--