Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF4E810DDC for ; Mon, 9 Dec 2013 22:39:05 +0000 (UTC) Received: (qmail 85214 invoked by uid 500); 9 Dec 2013 22:39:05 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 85195 invoked by uid 500); 9 Dec 2013 22:39:05 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 85185 invoked by uid 99); 9 Dec 2013 22:39:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Dec 2013 22:39:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0090F1C4A24; Mon, 9 Dec 2013 22:39:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1684894378416936622==" MIME-Version: 1.0 Subject: Re: Review Request 16099: Pass cli args to hooks, fix hooker.spec on windows. From: "Mark Koudritsky" To: "Mark Koudritsky" , "Michal Mocny" , "cordova" Date: Mon, 09 Dec 2013 22:39:04 -0000 Message-ID: <20131209223904.6673.17080@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Koudritsky" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/16099/ X-Sender: "Mark Koudritsky" References: <20131209221935.6673.68207@reviews.apache.org> In-Reply-To: <20131209221935.6673.68207@reviews.apache.org> Reply-To: "Mark Koudritsky" X-ReviewRequest-Repository: cordova-cli --===============1684894378416936622== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16099/ ----------------------------------------------------------- (Updated Dec. 9, 2013, 10:38 p.m.) Review request for cordova. Changes ------- add a forgotten "var" Bugs: CB-4382 and CB-5330 https://issues.apache.org/jira/browse/CB-4382 https://issues.apache.org/jira/browse/CB-5330 Repository: cordova-cli Description (updated) ------- Note: Two commits in diff (created as git format-patch). Same diff on github: https://github.com/kamrik/cordova-cli/compare/hv - Refactored the hooker.spec.js to use real files like the e2e tests. - Moved the spec and corresponding fixtures to live under e2e dir. - Rearranged the hooks fixtures into two separate dirs for Win and non-Win platforms. - e2e tests on windows can interfere with one another (seem to run partially in parallel), changed them to use different tmp subdirs for each test. Diffs (updated) ----- e2e/create.spec.js 3f1304c e2e/fixtures/hooks_bat/fail/fail.bat PRE-CREATION e2e/fixtures/hooks_bat/test/.dotted.bat PRE-CREATION e2e/fixtures/hooks_bat/test/07.bat PRE-CREATION e2e/fixtures/hooks_bat/test/1.bat PRE-CREATION e2e/fixtures/hooks_sh/fail/fail.sh PRE-CREATION e2e/fixtures/hooks_sh/test/.dotted.sh PRE-CREATION e2e/fixtures/hooks_sh/test/07.sh PRE-CREATION e2e/fixtures/hooks_sh/test/1.sh PRE-CREATION e2e/helpers.js aa1c790 e2e/hooker.spec.js PRE-CREATION e2e/platform.spec.js be5761e e2e/plugin.spec.js dd493bb package.json 6c1c753 spec/fixtures/hooks/fail/fail.bat 0c810b7 spec/fixtures/hooks/fail/fail.sh 379a4c9 spec/fixtures/hooks/test/07.bat 1095fc0 spec/fixtures/hooks/test/07.sh 6e25461 spec/fixtures/hooks/test/1.bat 4e76af0 spec/fixtures/hooks/test/1.sh 53d5e97 spec/hooker.spec.js d4b073e src/hooker.js 06acec7 Diff: https://reviews.apache.org/r/16099/diff/ Testing ------- npm test cordova prepare with dummy prepare hooks that store all environment variables. Thanks, Mark Koudritsky --===============1684894378416936622==--