cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: PluginEntry.java crash in getClassByName
Date Tue, 03 Dec 2013 23:13:07 GMT
Cool.  Feel free to close your pull request. We can't close it on our end. :(

On Tue, Dec 3, 2013 at 2:52 PM, Axel Nennker <ignisvulpis@gmail.com> wrote:
> Pull request is here: https://github.com/apache/cordova-android/pull/87
> I took the easier path to check for the empty string in PluginEntry.java
> instead of trying to find out what other effects a change in
> PluginManager.java from "" to null might have.
>
> Axel
>
>
> 2013/12/3 Axel Nennker <ignisvulpis@gmail.com>
>>
>> done:
>> https://issues.apache.org/jira/browse/CB-5537
>>
>>
>>
>> 2013/12/3 Joe Bowser <bowserj@gmail.com>
>>>
>>> Can you please create an issue so that this is tracked?
>>>
>>> On Tue, Dec 3, 2013 at 11:02 AM,  <Axel.Nennker@telekom.de> wrote:
>>> > Hi,
>>> >
>>> > I don't know why or since when but getClassByName is called with an
>>> > argument
>>> > of "" (not null).
>>> >
>>> > The method getClassByName checks for null but not for "" and so it
>>> > crashes.
>>> >
>>> > This happens for the service http://api.phonegap.com/1.0/device
>>> >
>>> > I am using cordova-3.1.0-0.2.0
>>> >
>>> > A screenshot of the debugging window is attached.
>>> >
>>> > A simple fix seems to be to never set this.pluginClass in
>>> > PluginEntry.java
>>> > to "" but to null. PluginManager.java contains the assignment:
>>> > pluginClass =
>>> > ""
>>> >
>>> >
>>> >
>>> > -Axel
>>> >
>>> >
>>
>>
>

Mime
View raw message