cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: review request for cordova-js gruntfile refactor
Date Wed, 11 Dec 2013 14:57:23 GMT
Brian - the 8 commits change is pretty overwhelming to look at all at once.
Could you split them up into those that you want looked at, and those that
you don't (e.g. lib->src & splitting gruntfile into separate files don't
really need to be looked at).


On Tue, Dec 10, 2013 at 11:04 PM, Brian LeRoux <b@brian.io> wrote:

> https://github.com/apache/cordova-js/pull/61
>
> In my quest to add the browser platform I got a little sidetracked cleaning
> up the gruntfile. Please have a look. The _btest fails currently but I
> think I want to move to phantom anyhow. Otherwise everything is identical.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message