cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Review Request 15775: Add --src & --link to "cordova create"
Date Mon, 23 Dec 2013 19:23:39 GMT
Merged.


On Mon, Dec 23, 2013 at 1:26 PM, Mark Koudritsky <kamrik@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15775/
>   Review request for cordova.
> By Mark Koudritsky.
>
> *Updated Dec. 23, 2013, 6:26 p.m.*
> Changes
>
> Removed random id for lazy_load, explicitly prohibiting --src=url with net urls (containing
colon), rebased on current master.
> Same diff on github https://github.com/kamrik/cordova-cli/compare/src_www
>
>   *Bugs: * CB-4153 <https://issues.apache.org/jira/browse/CB-4153>
>  *Repository: * cordova-cli
> Description
>
> Add --src & --link to "cordova create".
>
> Both --src and --source are accepted.
> The path is passed via the lib.www.uri of the configuration object
> that is later written to .cordova/config.json.
>
> Cordova will keep going into child www folder(s) of the provided path.
>
>   Testing
>
> npm test;
> cordova -d  create TstApp --source=some/www --link
> a bunch of other cordova commands in the app
>
>   Diffs (updated)
>
>    - doc/help.txt (3361dd3)
>    - e2e/create.spec.js (560f82a)
>    - spec/cli.spec.js (215c64c)
>    - spec/metadata/android_parser.spec.js (52fc78a)
>    - spec/metadata/ios_parser.spec.js (b56ddce)
>    - spec/metadata/windows8_parser.spec.js (5117148)
>    - spec/metadata/wp7_parser.spec.js (6dc0695)
>    - spec/metadata/wp8_parser.spec.js (8cd1923)
>    - src/cli.js (2916062)
>    - src/config_parser.js (b6293d8)
>    - src/create.js (77d9a69)
>    - src/metadata/wp8_parser.js (163d56b)
>
> View Diff <https://reviews.apache.org/r/15775/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message