cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Review request for CB-5579
Date Tue, 10 Dec 2013 02:52:06 GMT
Liyong, some context as to why you'd like to make this change would be nice
(what use-case does this address). Doing so will help reviewers get excited
about your change.

Also - you'll need to sign Apache's Contributor Agreement:
http://www.apache.org/licenses/#clas (can be done online).


On Mon, Dec 9, 2013 at 6:18 PM, Shazron <shazron@gmail.com> wrote:

> It's best also to file an issue at http://issues.cordova.io and include
> the
> patch:
>
> https://github.com/leyonh/cordova-plugman/commit/42ee27d1439bb676ea0c60fed46f9dd28e9d9e92.patch
>
> That might get more visibility - the team doesn't get emails for pull
> requests from Github (yet).
>
>
> On Sun, Dec 8, 2013 at 7:30 PM, Leyonh W <leyonh@gmail.com> wrote:
>
> > Hi,
> >
> > Can someone review the request ? Thanks in advance.
> >
> > https://github.com/apache/cordova-plugman/pull/37
> >
> > Cheers,
> > Liyong
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message