cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <purplecabb...@gmail.com>
Subject Re: Camera API: correctOrientation
Date Thu, 05 Dec 2013 19:16:11 GMT
Looking at the code for ios, correctOrientation doesn't modify exif, it rotates image bits.


Can you share your test app John?

Sent from my iPhone

> On Dec 5, 2013, at 7:42 AM, "John M. Wargo" <jwargo23@gmail.com> wrote:
> 
> That makes sense. As I only have this iOS 7 device, can someone do a quick test on an
older version of the OS?
> 
>> On 12/5/2013 9:51 AM, Andrew Grieve wrote:
>> One explanation is that the iOS camera now always rotates the image for you?
>> 
>> 
>>> On Thu, Dec 5, 2013 at 9:11 AM, John M. Wargo <jwargo23@gmail.com> wrote:
>>> 
>>> Jesse,
>>> 
>>> I've been thinking about what you said and I'm not getting it. I created
>>> an app that has three buttons, one takes a picture without
>>> correctOrientation even defined, another sets correctOrientation to true
>>> while the last one sets correctOrientation to false.
>>> 
>>> When I look at the photos on my Mac or in Windows Explorer, all three
>>> photos have the same orientation.
>>> 
>>> When I look at the EXIF properties in an EXIF editor, all three photos
>>> have orientation set the same value. The editor says its 0, but the field
>>> seems to be a two byte value which contains 00 01.
>>> 
>>> Since I'm comparing three photos at the same time, one of them should be
>>> turned on its side (the one where correctOrientation is true) while the
>>> other two are displayed in portrait orientation. That's expected behavior
>>> based on what you say below, but that's not what's happening for me.
>>> 
>>> I'm still leaning toward this particular option being broken.
>>> 
>>> 
>>>> On 12/4/2013 9:04 PM, Jesse wrote:
>>>> 
>>>> It definitely does something, you just may not notice it.
>>>> If you try to display an image you took in your app on iOS in any image
>>>> viewer that does not correctly interpret exif, then the picture will still
>>>> display correctly.
>>>> If you remove the code, it will not.
>>>> 
>>>> @purplecabbage
>>>> risingj.com
>>>> 
>>>> 
>>>> On Wed, Dec 4, 2013 at 5:59 PM, John M. Wargo <jwargo23@gmail.com>
wrote:
>>>> 
>>>> I can't get it to do anything on iOS, so I think it's broken.
>>>>> Any chance someone can do a quick test to confirm my suspicion? Probably
>>>>> need to remove it from the docs if it doesn't do anything.
>>>>> 
>>>>> 
>>>>> On 12/4/2013 8:41 PM, Jesse wrote:
>>>>> 
>>>>> It appears to do nothing, except on iOS.
>>>>>> It is listed as supported on iOS and Android, and back in 1.7, it
was
>>>>>> iOS
>>>>>> only,
>>>>>> 
>>>>>> Android does this:
>>>>>> this.correctOrientation = args.getBoolean(8);
>>>>>> 
>>>>>> iOS uses it after the image is captured, and calls
>>>>>> imageCorrectedForCaptureOrientation
>>>>>> [1] which rotates it according to the orientation of the camera when
the
>>>>>> picture was taken.
>>>>>> 
>>>>>> 
>>>>>> [1]
>>>>>> https://github.com/apache/cordova-plugin-camera/blob/
>>>>>> master/src/ios/CDVCamera.m#L455
>>>>>> 
>>>>>> 
>>>>>> @purplecabbage
>>>>>> risingj.com
>>>>>> 
>>>>>> 
>>>>>> On Wed, Dec 4, 2013 at 5:25 PM, Josh Soref <jsoref@blackberry.com>
>>>>>> wrote:
>>>>>> 
>>>>>>  John wrote:
>>>>>> 
>>>>>>> Can someone explain to me what correctOrientation is supposed
to do?
>>>>>>>> http://docs.phonegap.com/en/1.7.0/cordova_camera_camera.md.html
>>>>>>> Lists a bunch of platforms that don't implement it.
>>>>>>> 
>>>>>>> My guess is that some older platforms wouldn't automatically
switch
>>>>>>> between portrait and landscape orientations for photos.
>>>>>>> ---------------------------------------------------------------------
>>>>>>> This transmission (including any attachments) may contain confidential
>>>>>>> information, privileged material (including material protected
by the
>>>>>>> solicitor-client or other applicable privileges), or constitute
>>>>>>> non-public
>>>>>>> information. Any use of this information by anyone other than
the
>>>>>>> intended
>>>>>>> recipient is prohibited. If you have received this transmission
in
>>>>>>> error,
>>>>>>> please immediately reply to the sender and delete this information
from
>>>>>>> your system. Use, dissemination, distribution, or reproduction
of this
>>>>>>> transmission by unintended recipients is not authorized and may
be
>>>>>>> unlawful.
> 

Mime
View raw message