cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Re: Review Request 15775: Add --src & --link to "cordova create"
Date Thu, 12 Dec 2013 21:27:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15775/
-----------------------------------------------------------

(Updated Dec. 12, 2013, 9:27 p.m.)


Review request for cordova.


Changes
-------

--link was a boolean before, now it accepts a path, so it's either --src=path or --link=path.
Added a check in config_parser to make sure we are looking at an xml file that looks like
Cordova config.xml to avoid overwriting some unrelated config.xml when symlinking to www dir.

Same diff on github: https://github.com/kamrik/cordova-cli/compare/src_www


Bugs: CB-4153
    https://issues.apache.org/jira/browse/CB-4153


Repository: cordova-cli


Description
-------

Add --src & --link to "cordova create".

Both --src and --source are accepted.
The path is passed via the lib.www.uri of the configuration object
that is later written to .cordova/config.json.
    
Cordova will keep going into child www folder(s) of the provided path.


Diffs (updated)
-----

  doc/help.txt 3361dd3 
  e2e/create.spec.js 560f82a 
  spec/metadata/android_parser.spec.js 52fc78a 
  spec/metadata/ios_parser.spec.js b56ddce 
  spec/metadata/windows8_parser.spec.js 5117148 
  spec/metadata/wp7_parser.spec.js 6dc0695 
  spec/metadata/wp8_parser.spec.js 8cd1923 
  src/cli.js 2916062 
  src/config_parser.js b6293d8 
  src/create.js 961d787 
  src/metadata/wp8_parser.js 163d56b 

Diff: https://reviews.apache.org/r/15775/diff/


Testing
-------

npm test;
cordova -d  create TstApp --source=some/www --link
a bunch of other cordova commands in the app


Thanks,

Mark Koudritsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message