Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of v-segreb@microsoft.com
 designates 207.46.163.211 as permitted sender)
From: "Sergey Grebnov (Akvelon)" <v-segreb@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: Platforms which are in subdirectory in repositories can't be
 added by cli since 3.1.0-0.2.0
Thread-Topic: Platforms which are in subdirectory in repositories can't be
 added by cli since 3.1.0-0.2.0
Thread-Index: Ac7bGcd1M9KlKJ//TuGLXQcIFq9JbAAA1gWAAACGxUAAANyfAAAAj/IAAAZ4zhA=
Date: Wed, 6 Nov 2013 22:33:08 +0000
Message-ID: 
 <bac7cff46ad6452a8a25b9cdda60ca8b@BY2PR03MB345.namprd03.prod.outlook.com>
References: 
 <f902ca5f13ff4be783a0b64758e9665c@DBXPR03MB159.eurprd03.prod.outlook.com>
	<CAMk5LLmfQyeNNxjS4PTLmsye10ZKSOuR1cr09kk-W7Df8LRsPQ@mail.gmail.com>
	<539cdbb697c44b73b4ef9dbed7582ca5@DBXPR03MB159.eurprd03.prod.outlook.com>
	<CAMk5LLn+HtzvP7FX9Ho=KY9-NaeLZpVPm=nV6kKuCdA6p8MEsg@mail.gmail.com>
 <CAKP6k2vqikt7zobFG7LDgpMa-uVS0CymYGbqmzT91gBi+6F8eQ@mail.gmail.com>
In-Reply-To: 
 <CAKP6k2vqikt7zobFG7LDgpMa-uVS0CymYGbqmzT91gBi+6F8eQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Just a note, I've sent similar fix for this issue as per of CB-5183 WP7/8 l=
ib path is not correctly resolved by CLI. (a day ago)
https://github.com/apache/cordova-cli/pull/68

I've reviewed Maxime's changes and they  look good for me (except windows81=
 part which probably should be delayed) so I'm totally ok with merging any =
PR (my or Maxime).
=20
PS.
There was previously similar path rsolving logic in src/platform.js which w=
as removed as per the following changes
https://github.com/apache/cordova-cli/commit/d75c0585c88ee9283db400f0c94602=
7bd9d6e1ea=20

-            var bin =3D path.join(cordova_util.libDirectory, target, id, v=
ersion, 'bin', 'create');
-            if(target =3D=3D 'wp7') {
-                bin =3D path.join(cordova_util.libDirectory, 'wp', id, ver=
sion, 'wp7', 'bin', 'create');
-            }
-            else if(target =3D=3D 'wp8') {
-                bin =3D path.join(cordova_util.libDirectory, 'wp', id, ver=
sion, 'wp8', 'bin', 'create');
-            }
-            else if(target =3D=3D 'windows8') {
-                bin =3D path.join(cordova_util.libDirectory, 'windows8', i=
d, version, 'windows8', 'bin', 'create');
-            }

Thx!
Sergey
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]=20
Sent: Wednesday, November 6, 2013 11:18 PM
To: dev@cordova.apache.org
Subject: Re: Platforms which are in subdirectory in repositories can't be a=
dded by cli since 3.1.0-0.2.0

A few things:

I cannot find a record of a signed CLA for Maxime Luce.
I expect to see Maxime listed here:
https://people.apache.org/committer-index.html

The Windows 8.1 stuff should not be pulled in it's current state. 8.1 shoul=
d not be a new platform, but an update to 8.0. I plan to do this for
3.3.0

The subfolder changes to the cli should not be required, this was all worki=
ng, but there may have been a regression at some point, or something is out=
 of sync between the published version of the platforms and the cli.


@purplecabbage
risingj.com


On Wed, Nov 6, 2013 at 11:02 AM, Braden Shepherdson <braden@chromium.org>wr=
ote:

> There is existing special handling for blackberry10 scattered=20
> throughout the lazy-loading code. This will probably conflict with=20
> Maxime's changes and end in a path ending=20
> .../blackberry10/blackberry10. I'm not certain though, testing is require=
d.
>
> I've attached the log of the failed tests.
>
> Braden
>
>
> On Wed, Nov 6, 2013 at 1:50 PM, Maxime LUCE <Maxime@somatic.fr> wrote:
>
> > Braden,
> >
> > I comment on PR too,
> > I do not have test failure on my computer, which test fails on your=20
> > computer ?
> >
> > Cordialement.
> > ----------------------------
> > Maxime LUCE
> > maxime@touchit.fr
> > 06 28 60 72 34
> > http://touchit.fr
> >
> > -----Original Message-----
> > From: braden@google.com [mailto:braden@google.com] On Behalf Of=20
> > Braden Shepherdson
> > Sent: mercredi 6 novembre 2013 19:22
> > To: dev@cordova.apache.org
> > Subject: Re: Platforms which are in subdirectory in repositories=20
> > can't be added by cli since 3.1.0-0.2.0
> >
> > Commented on the PR.
> >
> >
> > On Wed, Nov 6, 2013 at 1:20 PM, Maxime LUCE <Maxime@somatic.fr> wrote:
> >
> > > Hello,
> > >
> > > I found that platforms which are in a subdirectory of their=20
> > > repository can't be added by cli.
> > > I found that in the commit=20
> > > d75c0585c88ee9283db400f0c946027bd9d6e1ea in cordova-cli repository, s=
omeone removed detection from these platforms.
> > >
> > > I created and resolved issue CB-5295 by doing a simple test over=20
> > > targeted platform.
> > > I think we must configure a "subdir" options in platforms.js to=20
> > > tell other modules that project can be in a sub directory in its repo=
sitory.
> > > What about that ? Can someone review and merge CB5295 ?
> > >
> > > You can find fix at :
> > > https://github.com/apache/cordova-cli/pull/69
> > >
> > > Cordialement.
> > > ----------------------------
> > > Maxime LUCE
> > > maxime@touchit.fr
> > > 06 28 60 72 34
> > > http://touchit.fr
> > >
> > >
> > >
> >
>