Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of csantana23@gmail.com
 designates 209.85.212.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAHYtTq=2ERrycEmXYxmK3PvXH-h32MGQE9emmZ33LwPDj9snNw@mail.gmail.com>
References: 
 <CA+X37c=Qh3x3wr3hQuPo62aKWAxgC9dMhp=CbiFh4mHamJhUQA@mail.gmail.com>
	<CAMk5LLksR7hy1HThMfVGHHNz93sAL4kT0xqYO4dEYTSAxTTHfA@mail.gmail.com>
	<CAHYtTqks1LhW+HVXY=fLsPNRTD5A6geouD0jV6LOXRDjwqk=Cw@mail.gmail.com>
	<CAHYtTq=2ERrycEmXYxmK3PvXH-h32MGQE9emmZ33LwPDj9snNw@mail.gmail.com>
Date: Tue, 5 Nov 2013 17:36:28 -0500
Message-ID: 
 <CAHYtTqm7jZLgYR5SoVGPN2vtvcj4OXTAKyk121tdz_g5BFtQ+Q@mail.gmail.com>
Subject: Re: Android target level for CLI
From: Carlos Santana <csantana23@gmail.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=f46d043c7dd2df533204ea75a944

--f46d043c7dd2df533204ea75a944
Content-Type: text/plain; charset=ISO-8859-1

Sorry wrong link for iOS Check Reqs
https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32

Should I open jira issues for these 2?


On Tue, Nov 5, 2013 at 5:31 PM, Carlos Santana <csantana23@gmail.com> wrote:

> Similar problem with iOS cheq_reqs
>
> CLI Checks for XCode 4.5 as min [1]
> Platform Checks for XCode 4.6 as min [2]
>
> Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-)
>
> [1]:
> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
> [2]:
> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>
>
>
> On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <csantana23@gmail.com>wrote:
>
>> Based on CLI Design [1]
>> The CLI should not hold the code to check requirements (i.e.
>> src/metadata/android_parser.js)
>>
>> The CLI instead should delegate to platform by calling
>> (platform/android/cordova/check_reqs)
>>
>>
>> Today there is duplicate of code not in sync for Android and iOS (other
>> platforms delegate to cheq_reqs):
>> CLI src/metadata/[platform]/check_requirements [2]
>> Platform cordova/check_reqs [3]
>>
>>
>>
>> [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
>> [2]:
>> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>> [3]:
>> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
>>
>>
>> On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <braden@chromium.org>wrote:
>>
>>> I don't know how this value got updated in the past, it should presumably
>>> be set to target the latest version of Android.
>>>
>>> +1 for bumping it to 19.
>>>
>>> Braden
>>>
>>>
>>> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
>>> wrote:
>>>
>>> > Hello,
>>> > Does anyone recall the reason for CLI to having "android-17" as a hard
>>> > target dependency.
>>> > --
>>> > Gorkem
>>> >
>>>
>>
>>
>>
>> --
>> Carlos Santana
>> <csantana23@gmail.com>
>>
>
>
>
> --
> Carlos Santana
> <csantana23@gmail.com>
>


-- 
Carlos Santana
<csantana23@gmail.com>

--f46d043c7dd2df533204ea75a944--