Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA6D210DF1 for ; Mon, 4 Nov 2013 21:07:25 +0000 (UTC) Received: (qmail 2564 invoked by uid 500); 4 Nov 2013 21:07:25 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 2543 invoked by uid 500); 4 Nov 2013 21:07:25 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 2535 invoked by uid 99); 4 Nov 2013 21:07:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Nov 2013 21:07:25 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of shazron@gmail.com designates 74.125.82.42 as permitted sender) Received: from [74.125.82.42] (HELO mail-wg0-f42.google.com) (74.125.82.42) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Nov 2013 21:07:21 +0000 Received: by mail-wg0-f42.google.com with SMTP id n12so2272293wgh.3 for ; Mon, 04 Nov 2013 13:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=Yce/HO/A1kW1wmBCT4NvjqK2oOjTnYVGI0g/eTi0DjI=; b=LkRA+TrKxVy9lWzd6qEUfY9jp8RYp2hVGw1IB33Q0tn9XfclQL9Qfqdan3iFtMehlj 1U4O0OXr99DCTEv9maDXq/xKOoVrkzvCptdFTrPesMZq5/ef+hCGOBlW+CCH1QUu8Fwu lH2AceBhtlin8c1xsa0epU4x+f82biOEJDc0ckrF8u23vKdLEgXaoBgJHpHANsbEz8B+ 2Euj5MOhdWu4sljMMzFnts5arxf9xHll+inRou5xLjz7XaYjMTXicDGbHMVis5tJv4rD Chghg7jpsjaPDRt+6QwW8QQD8WaWF3/nocA7lUhkPYGPiSi9xWUPF6EntPDLz36zGkGX 84nw== X-Received: by 10.194.47.209 with SMTP id f17mr3315407wjn.55.1383599220156; Mon, 04 Nov 2013 13:07:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.201.69 with HTTP; Mon, 4 Nov 2013 13:06:20 -0800 (PST) In-Reply-To: References: From: Shazron Date: Mon, 4 Nov 2013 13:06:20 -0800 Message-ID: Subject: Re: iOS only cordova-labs plugins (keyboard and statusbar, in plugins branch) - move to cordova-ios repo To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=047d7b86df460773bc04ea604c2e X-Virus-Checked: Checked by ClamAV on apache.org --047d7b86df460773bc04ea604c2e Content-Type: text/plain; charset=ISO-8859-1 cordova-plugins repo created https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;a=summary I'll start migrating by EOD cordova-labs/#plugins On Mon, Oct 21, 2013 at 9:13 AM, Shazron wrote: > INFRA request filed: https://issues.apache.org/jira/browse/INFRA-6902 > > > On Sat, Oct 19, 2013 at 3:36 PM, Brian LeRoux wrote: > >> Discreet repos do have value for discreet issue tracking IMO even when you >> use Jira. For example, feature branching is easier to reason about. >> >> /me shrugs >> >> One big repo to rule them all has created more problems than perceived >> benifits in our past experience so maybe I'm just allergic. >> >> On Saturday, October 19, 2013, Michal Mocny wrote: >> >> > Anis, when we were first ripping out the plugins getting ready for 3.0 >> we >> > didn't yet have support for plugins in git repo subdirs. I think we had >> > that functionality by 3.0 launch but by then we have created a bunch of >> > repos and momentum followed through. We *could* merge them all into a >> > cordova-plugins repo, but I'm not sure that has value. We *could* >> graduate >> > plugins out of cordova-plugins into discrete repos, but I'm not sure >> that >> > has value either. For end users, and for us devs, it really doesn't >> > matter, so we should do whats most comfortable. >> > >> > Brian, at the moment we aren't using github for issue tracking anyway, >> so >> > "discrete issue tracking" doesn't need to mean "discrete git repo". >> Likely >> > we do want to create a JIRA component for "graduated" plugins. The only >> > benefit to moving to discrete repos I can think of is consistency, which >> > may very well have value (esp for tooling support like coho). >> > >> > -Michal >> > >> > >> > On Fri, Oct 18, 2013 at 6:57 PM, Brian LeRoux wrote: >> > >> > > I think having a staging area for plugins is a good idea and leaving >> > > cordova-labs as a prototyping area. Ideally we graduate plugins out of >> > > cordova-plugins if they get any sort of traction at all and require >> > > discreet issue tracking. >> > > >> > > >> > > On Fri, Oct 18, 2013 at 1:31 PM, Anis KADRI >> > wrote: >> > > >> > > > I am just curious. Why do that only for those plugins only and not >> > > > every other plugins ? I know phonegap/phonegap-plugins was a bad >> idea >> > > > but since git 1.7 there is [1]. I've never used it but just figured >> it >> > > > might apply to our case. I also think namespacing is a bad idea. >> > > > >> > > > [1] >> http://schacon.github.io/git/git-read-tree.html#_sparse_checkout >> > > > >> > > > On Fri, Oct 18, 2013 at 12:57 PM, Shazron >> wrote: >> > > > > Great -- i *think* we have consensus, but I will wait until >> Monday to >> > > > move >> > > > > forward just in case. Here's my updated proposal on what has been >> > > > discussed >> > > > > today: >> > > > > >> > > > > 1. Ask INFRA to create a cordova-plugins repo >> > > > > 2. Move (with history) the cordova-labs plugins branch to the >> repo in >> > > (1) >> > > > > 3. Create a CordovaPreferences plugin in (1) with a generic API >> (and >> > > > > predefined constants) -- iOS to start >> > > > > >> > > > > >> > > > > On Fri, Oct 18, 2013 at 11:46 AM, Michal Mocny < >> mmocny@chromium.org> >> > > > wrote: >> > > > > >> > > > >> Sure we can debate the exact interface when it comes to it. >> Could >> > use >> > > > >> predefined constants instead of strings to help with >> > > > >> typing/discoverability: >> > > > >> >> > > > >> navigator.cordovaPreferences.setPreference(win, fail, >> > > > >> navigator.cordovaPreferences.PREFERENCE-iOS-GapBetweenPages, 0); >> > > > >> >> > > > >> >> > > > >> On Fri, Oct 18, 2013 at 2:17 PM, Shazron >> wrote: >> > > > >> >> > > > >> > Not feeling hot about the namespace thing - as Jesse said it >> might >> > > > limit >> > > > >> > us. Ok - if we do a cordova-plugins repo it won't be hard to >> move >> > > the >> > > > >> > plugins branch to it with a filter-branch option, preserving >> > history >> > > > -- >> > > > >> > great. >> > > > >> > >> > > > >> > I think a generic preferences plugin is ok (wouldn't be hard >> to >> > > > convert >> > > > >> > the interface anyway for the existing code I have for iOS) with >> > the >> > > > usual >> > > > >> > problems of user education/documentation for upgrades. Putting >> in >> > > the >> > > > >> > preference name itself might be error prone (who's a great >> speller >> > > > >> here?), >> > > > >> > but I would amend the pseudo code to actually have a >> > failure/success >> > > > >> > callback as well for these situations. >> > > > >> > >> > > > >> > navigator.cordovaPreferences.setPreference(win, fail, >> > > > >> > 'iOS-GapBetweenPages",0); >> > > > >> > navigator.cordovaPreferences.getPreference(win, fail, >> > > > >> > 'iOS-GapBetweenPages"); >> > > > >> > >> > > > >> > On Fri, Oct 18, 2013 at 10:59 AM, Jesse < >> purplecabbage@gmail.com> >> > > > wrote: >> > > > >> > >> > > > >> > > If you namespace it to the platform, and later it makes >> sense to >> > > > >> support >> > > > >> > it >> > > > >> > > on another device, you will have even more issues. >> > > > >> > > I think the best approach mentioned is the cordova-plugins >> repo >> > > > which >> > > > >> is >> > > > >> > > like the wild-west that is purplecabbage/phonegap-plugins >> except >> > > it >> > > > i >> > > --047d7b86df460773bc04ea604c2e--