Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of agrieve@google.com designates
 209.85.160.42 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAMk5LLkV5qyDdha-AbUO8egOCG24R_smt-HVCZmFEG9SdCnurA@mail.gmail.com>
References: 
 <CAMk5LLk6j1rqSHoTSqjyPYC=ePrHEycV2R-UuzhwCw8fyHKKnQ@mail.gmail.com>
 <CAEeF2Td4OYyEYukBYAP5fxDOm43HV3Eq_kE5jfFygQHsKr6JBw@mail.gmail.com>
 <CAEeF2TemAVgT-=+bE5W3Lti10EJmGHqvBnjXZ7tUFjGPR44zdg@mail.gmail.com>
 <299C48FD-159B-4A4F-9877-F2AF6105714C@gmail.com>
 <CAMk5LLk8Fwx+Efcn2zPLnjj2sb9wfDBLYaFrS9w7=7822a9n-w@mail.gmail.com>
 <CANpVHHxkvK4A0xsSMpajJjcJtzw5oXy59JOjmMLbD4AVURREUA@mail.gmail.com>
 <CAMk5LLkdxjBSc=F2R=jWPeE6JPtL8E_kbwLvoEbrpcW2viW4YA@mail.gmail.com>
 <CA+GVa3YbTY_u092ON7rQHMmi-_fExD3O1t3vDUA5ZvpRKOEs3g@mail.gmail.com>
 <CAASJe7-pN0vn7LsrX_seri55m=f2y=NPrVTpO_=4bpiPSfPadA@mail.gmail.com>
 <CAMk5LLnAkv57EU4se+Ym7ayqbb-G00U0gmoeXBDiG6oSZjQXSg@mail.gmail.com>
 <CABiQX1VYyvtHENsJe35Uk9wBhnOmgtcGf1QCq4hd5gPrb1-4BQ@mail.gmail.com>
 <CANpVHHzuBQLD1obETLp5MqN_oo9-3OK=uu8L1e0DU3y2aYZFEw@mail.gmail.com>
 <CANpVHHyVBE8BZiaaaG6-kz6QNsA8hQvwcGdVkHFe-eVKXvogQQ@mail.gmail.com>
 <CAMk5LLkV5qyDdha-AbUO8egOCG24R_smt-HVCZmFEG9SdCnurA@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Tue, 12 Nov 2013 22:57:23 -0500
Message-ID: 
 <CABiQX1V-mm-1Pz-uBSEjsHtf=A10fK0P177kNT7C4LL+krSqLw@mail.gmail.com>
Subject: Re: Refactoring the CLI tests
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b2e0a11983d7a04eb06f7ee

--047d7b2e0a11983d7a04eb06f7ee
Content-Type: text/plain; charset=ISO-8859-1

Great! If they pass - why not put them on master?


On Tue, Nov 12, 2013 at 5:52 PM, Braden Shepherdson <braden@chromium.org>wrote:

> Following up here with the note that there's a public branch called
> e2e-tests with working tests for create and platform commands. These tests
> are touching the real filesystem using only slightly hacked-up fixtures.
>
> A couple of things we learned: the res/ directory in the helloworld
> template is 3MB, the rest of the project including Android source and
> everything is about 280K. So drop the res/ directory from the fixtures, now
> it's much faster.
>
> We're having to inject into our freshly created project a config.json
> pointing at the fixtures instead of letting it do the real lazy-load, but
> that's working pretty well. They're fast, too, faster than some of the
> "unit" tests. Hopefully that trend will continue.
>
> Braden
>
>
> On Tue, Nov 12, 2013 at 4:56 PM, Anis KADRI <anis.kadri@gmail.com> wrote:
>
> > Wow...
> >
> > I meant
> >
> > "replace them with real world assertions (that touch the FS)". :-)
> >
> > On Tue, Nov 12, 2013 at 1:55 PM, Anis KADRI <anis.kadri@gmail.com>
> wrote:
> > > On Tue, Nov 12, 2013 at 1:49 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> > >> Want to give a big +1 to deleting tests that are testing
> implementation
> > >> rather than results. Having such tests is a real drain on
> productivity.
> > >
> > > I tend to agree with this statement. Maybe not delete but add/replace
> > > them real world assertions to them (that touch the FS). In some cases
> > > it makes sense to test the implementation to make sure that an action
> > > goes through the proper flow.
> >
>

--047d7b2e0a11983d7a04eb06f7ee--