Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of purplecabbage@gmail.com
 designates 209.85.160.49 as permitted sender)
Subject: Re: Platforms in subdirectory into repository
References: 
 <ab60d516e1d84fec910b7d45eb2e2bc0@DBXPR03MB159.eurprd03.prod.outlook.com>
 <CAEeRA4q+F2qBZhgcxLecvUatia46S1L+30XVOJ02y-FM4zEQeg@mail.gmail.com>
 <193db146e32944fa9ad4c5feb48ea90b@DBXPR03MB159.eurprd03.prod.outlook.com>
From: purplecabbage <purplecabbage@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: 
 <193db146e32944fa9ad4c5feb48ea90b@DBXPR03MB159.eurprd03.prod.outlook.com>
Message-Id: <52962904.0382440a.51b9.308d@mx.google.com>
Date: Wed, 27 Nov 2013 09:16:52 -0800
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)

I am currently testing it.=20
Tests are currently f'd on windows, so it is very difficult to both develop a=
nd test as you require both os's.=20
I am looking at fixing the way the tests are run so we can simplify this.=20=


Sent from my iPhone

> On Nov 27, 2013, at 7:31 AM, Maxime LUCE <Maxime@somatic.fr> wrote:
>=20
> I didn't test it specifically but I take it into account in my development=
.
> I removed the specific test for blackberry as it is standardized in lazy_l=
oad.js, you can see it at :
> https://github.com/apache/cordova-cli/pull/91/files#diff-a97c0300b0c3e7246=
7e54b438343f607L102
>=20
>=20
> Cordialement.
> ----------------------------
> Maxime LUCE
> maxime@touchit.fr
> 06 28 60 72 34
> http://touchit.fr
>=20
> -----Original Message-----
> From: bryan@bryanhiggins.net [mailto:bryan@bryanhiggins.net] On Behalf Of B=
ryan Higgins
> Sent: mercredi 27 novembre 2013 15:25
> To: dev@cordova.apache.org
> Subject: Re: Platforms in subdirectory into repository
>=20
> I like the idea of standardizing it this way. Was this patch tested on bb1=
0?
>=20
>=20
>> On Wed, Nov 27, 2013 at 6:21 AM, Maxime LUCE <Maxime@somatic.fr> wrote:
>>=20
>> In order to improve support of platforms in subdirectory,
>>=20
>> I created an improvement issue on JIRA :
>> https://issues.apache.org/jira/browse/CB-5392
>> Then I created a fix available here :
>> https://github.com/apache/cordova-cli/pull/91
>>=20
>> Do you agree with that way ?
>>=20
>>=20
>> Cordialement.
>> ----------------------------
>> Maxime LUCE
>> maxime@touchit.fr
>> 06 28 60 72 34
>> http://touchit.fr
>>=20
>> -----Original Message-----
>> From: braden@google.com [mailto:braden@google.com] On Behalf Of Braden=20=

>> Shepherdson
>> Sent: jeudi 14 novembre 2013 21:03
>> To: dev@cordova.apache.org
>> Subject: Re: Platforms which are in subdirectory in repositories can't=20=

>> be added by cli since 3.1.0-0.2.0
>>=20
>> That looks great to me. When this was just WP7+8 it was borderline=20
>> whether the special case was simpler, but I'd much rather turn that=20
>> special case code into an extra chunk of metadata now that there are=20
>> four or more platforms that need special handling.
>>=20
>> The more fiddly special cases we can eliminate the better.
>>=20
>> Braden
>>=20
>>=20
>>> On Thu, Nov 14, 2013 at 2:59 PM, Jesse <purplecabbage@gmail.com> wrote:
>>>=20
>>> I agree with this approach.  Non-existence of 'subdirectory' means=20
>>> the root is the root.
>>>=20
>>> platforms.js
>>>=20
>>> module.exports =3D {
>>>    'ios' : {
>>>        parser : './src/metadata/ios_parser',
>>>        url    : '
>>> https://git-wip-us.apache.org/repos/asf?p=3Dcordova-ios.git',
>>>        version: '3.2.0-rc1'
>>>    },
>>>    'android' : {
>>>        parser : './src/metadata/android_parser',
>>>        url    :
>>> 'https://git-wip-us.apache.org/repos/asf?p=3Dcordova-android.git',
>>>        version: '3.2.0-rc1'
>>>    },
>>>    'wp7' : {
>>>        parser : './src/metadata/wp7_parser',
>>>        url    : '
>>> https://git-wip-us.apache.org/repos/asf?p=3Dcordova-wp8.git',
>>>        version: '3.2.0-rc1',
>>>=20
>>>        subdirectory: 'wp7'
>>>=20
>>>    },
>>>    'wp8' : {
>>>        parser : './src/metadata/wp8_parser',
>>>        url :=20
>>> 'https://git-wip-us.apache.org/repos/asf?p=3Dcordova-wp8.git
>> ',
>>>        version: '3.2.0-rc1',
>>>=20
>>>        subdirectory: 'wp8'
>>>=20
>>>    },
>>> ...
>>>=20
>>>=20
>>>=20
>>> @purplecabbage
>>> risingj.com
>>>=20
>>>=20
>>>> On Thu, Nov 14, 2013 at 11:48 AM, Maxime LUCE <Maxime@somatic.fr> wrote=
:
>>>>=20
>>>> Hi,
>>>>=20
>>>> I fixed tests issues in https://github.com/apache/cordova-cli/pull/69.
>>>> I also added blackberry10 to platforms detection.
>>>>=20
>>>> This is a quick fix to make cli work again for those projects.
>>>> The best solution I think is to add a 'subdirectory' field in
>>> platforms.js
>>>> for any platform which is hosted in a sub directory into its
>>> repositories.
>>>> What do you think ?
>>>>=20
>>>> If you are ok with this, I can try a little fix.
>>>>=20
>>>> Cordialement.
>>>> ----------------------------
>>>> Maxime LUCE
>>>> maxime@touchit.fr
>>>> 06 28 60 72 34
>>>> http://touchit.fr
>>>>=20
>>>> -----Original Message-----
>>>> From: Sergey Grebnov (Akvelon) [mailto:v-segreb@microsoft.com]
>>>> Sent: mercredi 6 novembre 2013 23:33
>>>> To: dev@cordova.apache.org
>>>> Subject: RE: Platforms which are in subdirectory in repositories=20
>>>> can't be added by cli since 3.1.0-0.2.0
>>>>=20
>>>> Just a note, I've sent similar fix for this issue as per of=20
>>>> CB-5183
>>>> WP7/8 lib path is not correctly resolved by CLI. (a day ago)
>>>> https://github.com/apache/cordova-cli/pull/68
>>>>=20
>>>> I've reviewed Maxime's changes and they  look good for me (except
>>>> windows81 part which probably should be delayed) so I'm totally ok=20
>>>> with merging any PR (my or Maxime).
>>>>=20
>>>> PS.
>>>> There was previously similar path rsolving logic in=20
>>>> src/platform.js which was removed as per the following changes
>>> https://github.com/apache/cordova-cli/commit/d75c0585c88ee9283db400f
>>> 0c
>>> 946027bd9d6e1ea
>>>>=20
>>>> -            var bin =3D path.join(cordova_util.libDirectory, target, i=
d,
>>>> version, 'bin', 'create');
>>>> -            if(target =3D=3D 'wp7') {
>>>> -                bin =3D path.join(cordova_util.libDirectory, 'wp', id,=

>>>> version, 'wp7', 'bin', 'create');
>>>> -            }
>>>> -            else if(target =3D=3D 'wp8') {
>>>> -                bin =3D path.join(cordova_util.libDirectory, 'wp', id,=

>>>> version, 'wp8', 'bin', 'create');
>>>> -            }
>>>> -            else if(target =3D=3D 'windows8') {
>>>> -                bin =3D path.join(cordova_util.libDirectory, 'windows8=
',
>>>> id, version, 'windows8', 'bin', 'create');
>>>> -            }
>>>>=20
>>>> Thx!
>>>> Sergey
>>>> -----Original Message-----
>>>> From: Jesse [mailto:purplecabbage@gmail.com]
>>>> Sent: Wednesday, November 6, 2013 11:18 PM
>>>> To: dev@cordova.apache.org
>>>> Subject: Re: Platforms which are in subdirectory in repositories=20
>>>> can't be added by cli since 3.1.0-0.2.0
>>>>=20
>>>> A few things:
>>>>=20
>>>> I cannot find a record of a signed CLA for Maxime Luce.
>>>> I expect to see Maxime listed here:
>>>> https://people.apache.org/committer-index.html
>>>>=20
>>>> The Windows 8.1 stuff should not be pulled in it's current state.
>>>> 8.1 should not be a new platform, but an update to 8.0. I plan to=20
>>>> do this for
>>>> 3.3.0
>>>>=20
>>>> The subfolder changes to the cli should not be required, this was=20
>>>> all working, but there may have been a regression at some point,=20
>>>> or something is out of sync between the published version of the=20
>>>> platforms and the
>>> cli.
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> @purplecabbage
>>>> risingj.com
>>>>=20
>>>>=20
>>>> On Wed, Nov 6, 2013 at 11:02 AM, Braden Shepherdson=20
>>>> <braden@chromium.org
>>>>> wrote:
>>>>=20
>>>>> There is existing special handling for blackberry10 scattered=20
>>>>> throughout the lazy-loading code. This will probably conflict=20
>>>>> with Maxime's changes and end in a path ending=20
>>>>> .../blackberry10/blackberry10. I'm not certain though, testing=20
>>>>> is
>>>> required.
>>>>>=20
>>>>> I've attached the log of the failed tests.
>>>>>=20
>>>>> Braden
>>>>>=20
>>>>>=20
>>>>> On Wed, Nov 6, 2013 at 1:50 PM, Maxime LUCE <Maxime@somatic.fr>
>> wrote:
>>>>>=20
>>>>>> Braden,
>>>>>>=20
>>>>>> I comment on PR too,
>>>>>> I do not have test failure on my computer, which test fails on=20
>>>>>> your computer ?
>>>>>>=20
>>>>>> Cordialement.
>>>>>> ----------------------------
>>>>>> Maxime LUCE
>>>>>> maxime@touchit.fr
>>>>>> 06 28 60 72 34
>>>>>> http://touchit.fr
>>>>>>=20
>>>>>> -----Original Message-----
>>>>>> From: braden@google.com [mailto:braden@google.com] On Behalf=20
>>>>>> Of Braden Shepherdson
>>>>>> Sent: mercredi 6 novembre 2013 19:22
>>>>>> To: dev@cordova.apache.org
>>>>>> Subject: Re: Platforms which are in subdirectory in=20
>>>>>> repositories can't be added by cli since 3.1.0-0.2.0
>>>>>>=20
>>>>>> Commented on the PR.
>>>>>>=20
>>>>>>=20
>>>>>> On Wed, Nov 6, 2013 at 1:20 PM, Maxime LUCE=20
>>>>>> <Maxime@somatic.fr>
>>> wrote:
>>>>>>=20
>>>>>>> Hello,
>>>>>>>=20
>>>>>>> I found that platforms which are in a subdirectory of their=20
>>>>>>> repository can't be added by cli.
>>>>>>> I found that in the commit
>>>>>>> d75c0585c88ee9283db400f0c946027bd9d6e1ea in cordova-cli=20
>>>>>>> repository,
>>>> someone removed detection from these platforms.
>>>>>>>=20
>>>>>>> I created and resolved issue CB-5295 by doing a simple test=20
>>>>>>> over targeted platform.
>>>>>>> I think we must configure a "subdir" options in platforms.js=20
>>>>>>> to tell other modules that project can be in a sub directory=20
>>>>>>> in its
>>>> repository.
>>>>>>> What about that ? Can someone review and merge CB5295 ?
>>>>>>>=20
>>>>>>> You can find fix at :
>>>>>>> https://github.com/apache/cordova-cli/pull/69
>>>>>>>=20
>>>>>>> Cordialement.
>>>>>>> ---------------------------- Maxime LUCE maxime@touchit.fr
>>>>>>> 06 28 60 72 34
>>>>>>> http://touchit.fr
>>=20