Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3289310882 for ; Wed, 27 Nov 2013 21:59:39 +0000 (UTC) Received: (qmail 8376 invoked by uid 500); 27 Nov 2013 21:59:38 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 8352 invoked by uid 500); 27 Nov 2013 21:59:38 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 8342 invoked by uid 99); 27 Nov 2013 21:59:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 21:59:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 64A691D3C5A; Wed, 27 Nov 2013 21:59:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0592768103093165211==" MIME-Version: 1.0 Subject: Re: Review Request 15889: [android] call out to platform check_req script From: "Braden Shepherdson" To: "Braden Shepherdson" , "cordova" , "Michal Mocny" Date: Wed, 27 Nov 2013 21:59:34 -0000 Message-ID: <20131127215934.21309.78923@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Braden Shepherdson" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/15889/ X-Sender: "Braden Shepherdson" References: <20131127215108.10923.47904@reviews.apache.org> In-Reply-To: <20131127215108.10923.47904@reviews.apache.org> Reply-To: "Braden Shepherdson" X-ReviewRequest-Repository: cordova-cli --===============0592768103093165211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15889/#review29517 ----------------------------------------------------------- src/metadata/android_parser.js This is duplicating the logic in the lazy loader for checking for custom configs and so on. The correct flow is: lazy_load.based_on_config(project_root, 'android').then(function(lib_path) { // shell out to lib_path/bin/check_reqs }); - Braden Shepherdson On Nov. 27, 2013, 9:51 p.m., Michal Mocny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15889/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 9:51 p.m.) > > > Review request for cordova. > > > Repository: cordova-cli > > > Description > ------- > > . > > > Diffs > ----- > > src/metadata/android_parser.js 535d5b2 > > Diff: https://reviews.apache.org/r/15889/diff/ > > > Testing > ------- > > > Thanks, > > Michal Mocny > > --===============0592768103093165211==--