Return-Path: 
 <dev-return-28190-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 31AF9100DD
	for <apmail-cordova-dev-archive@www.apache.org>;
 Thu, 21 Nov 2013 16:06:28 +0000 (UTC)
Received: (qmail 94045 invoked by uid 500); 21 Nov 2013 16:06:27 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 93892 invoked by uid 500); 21 Nov 2013 16:06:20 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 93860 invoked by uid 99); 21 Nov 2013 16:06:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2013 16:06:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id E61DC1D377C;
	Thu, 21 Nov 2013 16:06:12 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0298531069802662416=="
MIME-Version: 1.0
Subject: Re: Review Request 15750: Adding/Removing custom frameworks to iOS
 projects
From: "Braden Shepherdson" <braden@chromium.org>
To: "Braden Shepherdson" <braden@chromium.org>,
 "Max Woghiren" <maxw@chromium.org>
Cc: "Anis Kadri" <anis@apache.org>, "cordova" <dev@cordova.apache.org>
Date: Thu, 21 Nov 2013 16:06:12 -0000
Message-ID: <20131121160612.1417.45404@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Braden Shepherdson" <noreply@reviews.apache.org>
X-ReviewGroup: cordova
X-ReviewRequest-URL: https://reviews.apache.org/r/15750/
X-Sender: "Braden Shepherdson" <noreply@reviews.apache.org>
References: <20131121032636.6018.11740@reviews.apache.org>
In-Reply-To: <20131121032636.6018.11740@reviews.apache.org>
Reply-To: "Braden Shepherdson" <braden@chromium.org>
X-ReviewRequest-Repository: cordova-plugman

--===============0298531069802662416==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15750/#review29231
-----------------------------------------------------------


I share Ian's concern about the removal. Though possibly since these are custom, bundled frameworks, there will never be any overlap. If so, then it's fine.

- Braden Shepherdson


On Nov. 21, 2013, 3:26 a.m., Anis Kadri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15750/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 3:26 a.m.)
> 
> 
> Review request for cordova, Max Woghiren and Braden Shepherdson.
> 
> 
> Bugs: CB-5238
>     https://issues.apache.org/jira/browse/CB-5238
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> -------
> 
> Adding/Removing custom frameworks to iOS projects
> 
> node-xcode 0.6.3 needs to be pushed to npm for this to be tested.
> 
> Custom frameworks can be defined in plugin.xml like so:
> 
> <framework src="src/ios/Custom.framework" custom="true">
> 
> if @custom="true" is not defined, plugman will think it is a System framework and will therefore fail to add it properly.
> 
> 
> Diffs
> -----
> 
>   spec/platforms/ios.spec.js cb7460d 
>   spec/plugins/ChildBrowser/plugin.xml 512c02f 
>   spec/plugins/DummyPlugin/plugin.xml fad5072 
>   spec/plugins/FaultyPlugin/plugin.xml 30af6e7 
>   spec/util/config-changes.spec.js 5e46b69 
>   src/install.js c0a4de9 
>   src/platforms/ios.js 065c4a7 
>   src/uninstall.js 11ff7fb 
>   src/util/config-changes.js 0239b61 
> 
> Diff: https://reviews.apache.org/r/15750/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anis Kadri
> 
>


--===============0298531069802662416==--