cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: Platforms which are in subdirectory in repositories can't be added by cli since 3.1.0-0.2.0
Date Wed, 06 Nov 2013 19:18:08 GMT
A few things:

I cannot find a record of a signed CLA for Maxime Luce.
I expect to see Maxime listed here:
https://people.apache.org/committer-index.html

The Windows 8.1 stuff should not be pulled in it's current state. 8.1
should not be a new platform, but an update to 8.0. I plan to do this for
3.3.0

The subfolder changes to the cli should not be required, this was all
working, but there may have been a regression at some point, or something
is out of sync between the published version of the platforms and the cli.







@purplecabbage
risingj.com


On Wed, Nov 6, 2013 at 11:02 AM, Braden Shepherdson <braden@chromium.org>wrote:

> There is existing special handling for blackberry10 scattered throughout
> the lazy-loading code. This will probably conflict with Maxime's changes
> and end in a path ending .../blackberry10/blackberry10. I'm not certain
> though, testing is required.
>
> I've attached the log of the failed tests.
>
> Braden
>
>
> On Wed, Nov 6, 2013 at 1:50 PM, Maxime LUCE <Maxime@somatic.fr> wrote:
>
> > Braden,
> >
> > I comment on PR too,
> > I do not have test failure on my computer, which test fails on your
> > computer ?
> >
> > Cordialement.
> > ----------------------------
> > Maxime LUCE
> > maxime@touchit.fr
> > 06 28 60 72 34
> > http://touchit.fr
> >
> > -----Original Message-----
> > From: braden@google.com [mailto:braden@google.com] On Behalf Of Braden
> > Shepherdson
> > Sent: mercredi 6 novembre 2013 19:22
> > To: dev@cordova.apache.org
> > Subject: Re: Platforms which are in subdirectory in repositories can't be
> > added by cli since 3.1.0-0.2.0
> >
> > Commented on the PR.
> >
> >
> > On Wed, Nov 6, 2013 at 1:20 PM, Maxime LUCE <Maxime@somatic.fr> wrote:
> >
> > > Hello,
> > >
> > > I found that platforms which are in a subdirectory of their repository
> > > can't be added by cli.
> > > I found that in the commit d75c0585c88ee9283db400f0c946027bd9d6e1ea in
> > > cordova-cli repository, someone removed detection from these platforms.
> > >
> > > I created and resolved issue CB-5295 by doing a simple test over
> > > targeted platform.
> > > I think we must configure a "subdir" options in platforms.js to tell
> > > other modules that project can be in a sub directory in its repository.
> > > What about that ? Can someone review and merge CB5295 ?
> > >
> > > You can find fix at :
> > > https://github.com/apache/cordova-cli/pull/69
> > >
> > > Cordialement.
> > > ----------------------------
> > > Maxime LUCE
> > > maxime@touchit.fr
> > > 06 28 60 72 34
> > > http://touchit.fr
> > >
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message