cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: CLI testing
Date Wed, 27 Nov 2013 21:25:57 GMT
they all live in their own folder, so it is easy to run tests without
running e2e tests. ( ie we do at least have some good separation )
Just modify package.json 's scripts{test:} to not include e2e/ until they
are fixed.

@purplecabbage
risingj.com


On Wed, Nov 27, 2013 at 1:20 PM, Lorin Beer <lorin.beer.dev@gmail.com>wrote:

> +1 on reverting these out. Pushing large commits that causes widespread
> failing tests on one or more platforms should be reverted out. They should
> not be pushed up to master in the first place.
>
>
> On Wed, Nov 27, 2013 at 1:16 PM, Steven Gill <stevengill97@gmail.com>
> wrote:
>
> > I think we should revert these out and put them on a branch until ready.
> >
> > Thoughts?
> >
> >
> > On Wed, Nov 27, 2013 at 12:59 PM, Jesse <purplecabbage@gmail.com> wrote:
> >
> > > okay, yeah, just switched over to OSX, and there are numerous (59)
> > failures
> > > here too as well.
> > >
> > > I have verified that these are all a result of the e2e tests folder, if
> > you
> > > run :
> > > jasmine-node --color spec
> > >
> > > You will not see any of these failures.
> > >
> > > blame @mmocny ;)
> > >
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Wed, Nov 27, 2013 at 12:44 PM, David Kemp <drkemp@chromium.org>
> > wrote:
> > >
> > > > a recent set of commits landed about 1/2 hour ago has broken the CLI
> > > tests
> > > >
> > > > 343 tests, 572 assertions, 59 failures
> > > >
> > > >
> > > > looks like most are : Error: ENOENT, no such file or directory
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message